From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 0D89F37B3; Fri, 7 Apr 2017 11:14:42 +0200 (CEST) In-Reply-To: References: To: test-report@dpdk.org Cc: Zhang Lei Message-Id: <20170407091442.0D89F37B3@dpdk.org> Date: Fri, 7 Apr 2017 11:14:42 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw23315 [PATCH] net: support PPPOE in software packet type parser X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 09:14:42 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/23315 _coding style issues_ WARNING:LEADING_SPACE: please, no spaces at the start of a line #56: FILE: lib/librte_net/rte_ether.h:330: + uint8_t type_ver;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #57: FILE: lib/librte_net/rte_ether.h:331: + uint8_t code;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #58: FILE: lib/librte_net/rte_ether.h:332: + uint16_t sid;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #59: FILE: lib/librte_net/rte_ether.h:333: + uint16_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #60: FILE: lib/librte_net/rte_ether.h:334: + uint16_t proto;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #81: FILE: lib/librte_net/rte_net.c:305: + } else if (proto == rte_cpu_to_be_16(ETHER_TYPE_PPPOE)) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (1, 1) #81: FILE: lib/librte_net/rte_net.c:305: + } else if (proto == rte_cpu_to_be_16(ETHER_TYPE_PPPOE)) { + const struct pppoe_hdr *ph; WARNING:LEADING_SPACE: please, no spaces at the start of a line #82: FILE: lib/librte_net/rte_net.c:306: + const struct pppoe_hdr *ph;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #83: FILE: lib/librte_net/rte_net.c:307: + struct pppoe_hdr ph_copy;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #85: FILE: lib/librte_net/rte_net.c:309: + pkt_type = RTE_PTYPE_L2_ETHER_PPPOE;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #86: FILE: lib/librte_net/rte_net.c:310: + ph = rte_pktmbuf_read(m, off, sizeof(*ph), &ph_copy);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #87: FILE: lib/librte_net/rte_net.c:311: + if (unlikely(ph == NULL))$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (1, 1) #87: FILE: lib/librte_net/rte_net.c:311: + if (unlikely(ph == NULL)) + return pkt_type; WARNING:LEADING_SPACE: please, no spaces at the start of a line #88: FILE: lib/librte_net/rte_net.c:312: + return pkt_type;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #90: FILE: lib/librte_net/rte_net.c:314: + off += sizeof(*ph);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #91: FILE: lib/librte_net/rte_net.c:315: + hdr_lens->l2_len += sizeof(*ph);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #92: FILE: lib/librte_net/rte_net.c:316: + if (ph->code != 0) /* Not Seesion Data */$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (1, 1) #92: FILE: lib/librte_net/rte_net.c:316: + if (ph->code != 0) /* Not Seesion Data */ + return pkt_type; WARNING:LEADING_SPACE: please, no spaces at the start of a line #93: FILE: lib/librte_net/rte_net.c:317: + return pkt_type;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #94: FILE: lib/librte_net/rte_net.c:318: + if (ph->proto == rte_cpu_to_be_16(0x21))$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (1, 1) #94: FILE: lib/librte_net/rte_net.c:318: + if (ph->proto == rte_cpu_to_be_16(0x21)) + proto = rte_cpu_to_be_16(ETHER_TYPE_IPv4); WARNING:LEADING_SPACE: please, no spaces at the start of a line #95: FILE: lib/librte_net/rte_net.c:319: + proto = rte_cpu_to_be_16(ETHER_TYPE_IPv4);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #96: FILE: lib/librte_net/rte_net.c:320: + else if (ph->proto == rte_cpu_to_be_16(0x57))$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (1, 1) #96: FILE: lib/librte_net/rte_net.c:320: + else if (ph->proto == rte_cpu_to_be_16(0x57)) + proto = rte_cpu_to_be_16(ETHER_TYPE_IPv6); WARNING:LEADING_SPACE: please, no spaces at the start of a line #97: FILE: lib/librte_net/rte_net.c:321: + proto = rte_cpu_to_be_16(ETHER_TYPE_IPv6);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #98: FILE: lib/librte_net/rte_net.c:322: + else$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #99: FILE: lib/librte_net/rte_net.c:323: + return pkt_type;$ total: 0 errors, 27 warnings, 62 lines checked