automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>
Subject: [dpdk-test-report] |WARNING| pw23784 [PATCH] CLI parsing issue
Date: Thu, 20 Apr 2017 10:37:29 +0200 (CEST)	[thread overview]
Message-ID: <20170420083729.2D76F388F@dpdk.org> (raw)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B59B248@shsmsx102.ccr.corp.intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/23784

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#16: 
I checked this function, cmdline_parse. It will check the CLI instances one by one. Even if an instance is matched, the parsing will not stop for ambiguous check. Seems the following check may change the parsing result of the previous one,

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#38: FILE: lib/librte_cmdline/cmdline_parse.c:262:
+       char tmp_buf[CMDLINE_PARSE_RESULT_BUFSIZE];$

ERROR:CODE_INDENT: code indent should use tabs where possible
#47: FILE: lib/librte_cmdline/cmdline_parse.c:325:
+               tok = match_inst(inst, buf, 0, tmp_buf, sizeof(tmp_buf),$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#47: FILE: lib/librte_cmdline/cmdline_parse.c:325:
+               tok = match_inst(inst, buf, 0, tmp_buf, sizeof(tmp_buf),$

ERROR:CODE_INDENT: code indent should use tabs where possible
#55: FILE: lib/librte_cmdline/cmdline_parse.c:333:
+                       memcpy(result.buf, tmp_buf,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#55: FILE: lib/librte_cmdline/cmdline_parse.c:333:
+                       memcpy(result.buf, tmp_buf,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#56: FILE: lib/librte_cmdline/cmdline_parse.c:334:
+                              CMDLINE_PARSE_RESULT_BUFSIZE);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#56: FILE: lib/librte_cmdline/cmdline_parse.c:334:
+                              CMDLINE_PARSE_RESULT_BUFSIZE);$

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 4 errors, 5 warnings, 23 lines checked

           reply	other threads:[~2017-04-20  8:37 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <6A0DE07E22DDAD4C9103DF62FEBC09093B59B248@shsmsx102.ccr.corp.intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170420083729.2D76F388F@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=test-report@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).