* [dpdk-test-report] |WARNING| pw23784 [PATCH] CLI parsing issue
[not found] <6A0DE07E22DDAD4C9103DF62FEBC09093B59B248@shsmsx102.ccr.corp.intel.com>
@ 2017-04-20 8:37 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-04-20 8:37 UTC (permalink / raw)
To: test-report; +Cc: Wenzhuo Lu
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/23784
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#16:
I checked this function, cmdline_parse. It will check the CLI instances one by one. Even if an instance is matched, the parsing will not stop for ambiguous check. Seems the following check may change the parsing result of the previous one,
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#38: FILE: lib/librte_cmdline/cmdline_parse.c:262:
+ char tmp_buf[CMDLINE_PARSE_RESULT_BUFSIZE];$
ERROR:CODE_INDENT: code indent should use tabs where possible
#47: FILE: lib/librte_cmdline/cmdline_parse.c:325:
+ tok = match_inst(inst, buf, 0, tmp_buf, sizeof(tmp_buf),$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#47: FILE: lib/librte_cmdline/cmdline_parse.c:325:
+ tok = match_inst(inst, buf, 0, tmp_buf, sizeof(tmp_buf),$
ERROR:CODE_INDENT: code indent should use tabs where possible
#55: FILE: lib/librte_cmdline/cmdline_parse.c:333:
+ memcpy(result.buf, tmp_buf,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#55: FILE: lib/librte_cmdline/cmdline_parse.c:333:
+ memcpy(result.buf, tmp_buf,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#56: FILE: lib/librte_cmdline/cmdline_parse.c:334:
+ CMDLINE_PARSE_RESULT_BUFSIZE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#56: FILE: lib/librte_cmdline/cmdline_parse.c:334:
+ CMDLINE_PARSE_RESULT_BUFSIZE);$
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 4 errors, 5 warnings, 23 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-04-20 8:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <6A0DE07E22DDAD4C9103DF62FEBC09093B59B248@shsmsx102.ccr.corp.intel.com>
2017-04-20 8:37 ` [dpdk-test-report] |WARNING| pw23784 [PATCH] CLI parsing issue checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).