From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 2D76F388F; Thu, 20 Apr 2017 10:37:29 +0200 (CEST)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B59B248@shsmsx102.ccr.corp.intel.com>
References: <6A0DE07E22DDAD4C9103DF62FEBC09093B59B248@shsmsx102.ccr.corp.intel.com>
To: test-report@dpdk.org
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>
Message-Id: <20170420083729.2D76F388F@dpdk.org>
Date: Thu, 20 Apr 2017 10:37:29 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw23784 [PATCH] CLI parsing issue
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Apr 2017 08:37:29 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/23784

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#16: 
I checked this function, cmdline_parse. It will check the CLI instances one by one. Even if an instance is matched, the parsing will not stop for ambiguous check. Seems the following check may change the parsing result of the previous one,

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#38: FILE: lib/librte_cmdline/cmdline_parse.c:262:
+       char tmp_buf[CMDLINE_PARSE_RESULT_BUFSIZE];$

ERROR:CODE_INDENT: code indent should use tabs where possible
#47: FILE: lib/librte_cmdline/cmdline_parse.c:325:
+               tok = match_inst(inst, buf, 0, tmp_buf, sizeof(tmp_buf),$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#47: FILE: lib/librte_cmdline/cmdline_parse.c:325:
+               tok = match_inst(inst, buf, 0, tmp_buf, sizeof(tmp_buf),$

ERROR:CODE_INDENT: code indent should use tabs where possible
#55: FILE: lib/librte_cmdline/cmdline_parse.c:333:
+                       memcpy(result.buf, tmp_buf,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#55: FILE: lib/librte_cmdline/cmdline_parse.c:333:
+                       memcpy(result.buf, tmp_buf,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#56: FILE: lib/librte_cmdline/cmdline_parse.c:334:
+                              CMDLINE_PARSE_RESULT_BUFSIZE);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#56: FILE: lib/librte_cmdline/cmdline_parse.c:334:
+                              CMDLINE_PARSE_RESULT_BUFSIZE);$

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 4 errors, 5 warnings, 23 lines checked