automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Guduri Prathyusha <Guduri.Prathyusha@cavium.com>
Subject: [dpdk-test-report] |WARNING| pw23896 [PATCH] dpdk-devbind can't be used misc with kernel tools
Date: Wed, 26 Apr 2017 11:26:32 +0200 (CEST)	[thread overview]
Message-ID: <20170426092632.BBEBB58FE@dpdk.org> (raw)
In-Reply-To: <BY2PR0701MB2101C4F186FF56EFF3F0B1238F110@BY2PR0701MB2101.namprd07.prod.outlook.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/23896

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#20: 
Kindly apply the patch below (inline) and let me know the result. I will submit a formal patch once you confirm.

ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Prathyusha, Guduri'
#30: 
To: Prathyusha, Guduri

ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
#60: 
dpdk commit eba33e87ad37626604be7186e746751f99691084

ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
#82: 
commit 2fc3502935700243d9a6d903166e6fd11e429843

ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
#87: 
commit c3ce205d5729867bd1c4c4429a80e01a528d5905

ERROR:DIFF_IN_COMMIT_MSG: Avoid using diff content in the commit message - patch(1) might not work
#94: 
--- a/usertools/dpdk-devbind.py                                                 

ERROR:TRAILING_WHITESPACE: trailing whitespace
#126: FILE: usertools/dpdk-devbind.py:491:
+    # For kernels > 3.15 driver_override is used to bind a device to a driver. $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#127: FILE: usertools/dpdk-devbind.py:492:
+    # Before unbinding it, overwrite driver_override with empty string so that $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#128: FILE: usertools/dpdk-devbind.py:493:
+    # the device can be bound to any other driver                              $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#129: FILE: usertools/dpdk-devbind.py:494:
+    filename = "/sys/bus/pci/devices/%s/driver_override" % dev_id              $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#130: FILE: usertools/dpdk-devbind.py:495:
+    if os.path.exists(filename):                                               $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#131: FILE: usertools/dpdk-devbind.py:496:
+        try:                                                                   $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#132: FILE: usertools/dpdk-devbind.py:497:
+            f = open(filename, "w")                                            $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#133: FILE: usertools/dpdk-devbind.py:498:
+        except:                                                                $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#134: FILE: usertools/dpdk-devbind.py:499:
+            print("Error: unbind failed for %s - Cannot open %s"               $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#135: FILE: usertools/dpdk-devbind.py:500:
+                  % (dev_id, filename))                                        $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#136: FILE: usertools/dpdk-devbind.py:501:
+            sys.exit(1)                                                        $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#137: FILE: usertools/dpdk-devbind.py:502:
+        try:                                                                   $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#138: FILE: usertools/dpdk-devbind.py:503:
+            f.write("

           reply	other threads:[~2017-04-26  9:26 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <BY2PR0701MB2101C4F186FF56EFF3F0B1238F110@BY2PR0701MB2101.namprd07.prod.outlook.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170426092632.BBEBB58FE@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=Guduri.Prathyusha@cavium.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).