From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Michael Lilja <ml@napatech.com>
Subject: [dpdk-test-report] |WARNING| pw23903 [PATCH] drivers/net/i40e/i40e_fdir.c: Improved i40e FDIR programming times
Date: Wed, 26 Apr 2017 13:16:51 +0200 (CEST) [thread overview]
Message-ID: <20170426111651.4DDB52C50@dpdk.org> (raw)
In-Reply-To: <b06319b02a2e4cd39c2b791fe7f90d5b@napatech.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/23903
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#16:
During my work (https://www.napatech.com/hw-acceleration-via-rte_flow/)on a flowtable application example that use rte_flow I discovered that the rte_flow programming times on a i40e was +11ms. The patch below result in an average programming time of 22usec with a max of 60usec instead of +11ms.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#35: FILE: drivers/net/i40e/i40e_fdir.c:1298:
+ for (i = 0; i < (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US); i++) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (5, 10)
#35: FILE: drivers/net/i40e/i40e_fdir.c:1298:
+ for (i = 0; i < (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US); i++) {
if ((txdp->cmd_type_offset_bsz &
ERROR:CODE_INDENT: code indent should use tabs where possible
#40: FILE: drivers/net/i40e/i40e_fdir.c:1303:
+ rte_delay_us(1);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#40: FILE: drivers/net/i40e/i40e_fdir.c:1303:
+ rte_delay_us(1);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#43: FILE: drivers/net/i40e/i40e_fdir.c:1305:
+ if (i >= (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US)) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (5, 10)
#43: FILE: drivers/net/i40e/i40e_fdir.c:1305:
+ if (i >= (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US)) {
PMD_DRV_LOG(ERR, "Failed to program FDIR filter:"
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#50: FILE: drivers/net/i40e/i40e_fdir.c:1311:
+ uint32_t w;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#51: FILE: drivers/net/i40e/i40e_fdir.c:1312:
+ for (w = 0; w < (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US); w++) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (5, 11)
#51: FILE: drivers/net/i40e/i40e_fdir.c:1312:
+ for (w = 0; w < (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US); w++) {
+ if (i40e_check_fdir_programming_status(rxq) >= 0) {
ERROR:CODE_INDENT: code indent should use tabs where possible
#52: FILE: drivers/net/i40e/i40e_fdir.c:1313:
+ if (i40e_check_fdir_programming_status(rxq) >= 0) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#52: FILE: drivers/net/i40e/i40e_fdir.c:1313:
+ if (i40e_check_fdir_programming_status(rxq) >= 0) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (11, 17)
#52: FILE: drivers/net/i40e/i40e_fdir.c:1313:
+ if (i40e_check_fdir_programming_status(rxq) >= 0) {
+ break;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#52: FILE: drivers/net/i40e/i40e_fdir.c:1313:
+ if (i40e_check_fdir_programming_status(rxq) >= 0) {
+ break;
+ }
ERROR:CODE_INDENT: code indent should use tabs where possible
#53: FILE: drivers/net/i40e/i40e_fdir.c:1314:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#53: FILE: drivers/net/i40e/i40e_fdir.c:1314:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#54: FILE: drivers/net/i40e/i40e_fdir.c:1315:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#54: FILE: drivers/net/i40e/i40e_fdir.c:1315:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#55: FILE: drivers/net/i40e/i40e_fdir.c:1316:
+ rte_delay_us(1);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#55: FILE: drivers/net/i40e/i40e_fdir.c:1316:
+ rte_delay_us(1);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#56: FILE: drivers/net/i40e/i40e_fdir.c:1317:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#60: FILE: drivers/net/i40e/i40e_fdir.c:1320:
+ " programming status reported.");$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#60: FILE: drivers/net/i40e/i40e_fdir.c:1320:
+ " programming status reported.");$
ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#64: FILE: drivers/net/i40e/i40e_fdir.c:1322:
Disclaimer: This email and any files transmitted with it may contain confidential information intended for the addressee(s) only. The information is not to be surrendered or copied to unauthorized persons. If you have received this communication in error, please notify the sender immediately and delete this e-mail from your system.
total: 7 errors, 17 warnings, 0 checks, 35 lines checked
parent reply other threads:[~2017-04-26 11:16 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <b06319b02a2e4cd39c2b791fe7f90d5b@napatech.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170426111651.4DDB52C50@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=ml@napatech.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).