[dpdk-test-report] |WARNING| pw23903 [PATCH] drivers/net/i40e/i40e_fdir.c: Improved i40e FDIR programming times

[dpdk-test-report] |WARNING| pw23903 [PATCH] drivers/net/i40e/i40e_fdir.c: Improved i40e FDIR programming times

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/23903

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#16: 
During my work (https://www.napatech.com/hw-acceleration-via-rte_flow/)on a flowtable application example that use rte_flow I discovered that the rte_flow programming times on a i40e was +11ms. The patch below result in an average programming time of 22usec with a max of 60usec instead of +11ms.

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#35: FILE: drivers/net/i40e/i40e_fdir.c:1298:
+     for (i = 0; i < (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US); i++) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (5, 10)
#35: FILE: drivers/net/i40e/i40e_fdir.c:1298:
+     for (i = 0; i < (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US); i++) {
           if ((txdp->cmd_type_offset_bsz &

ERROR:CODE_INDENT: code indent should use tabs where possible
#40: FILE: drivers/net/i40e/i40e_fdir.c:1303:
+           rte_delay_us(1);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#40: FILE: drivers/net/i40e/i40e_fdir.c:1303:
+           rte_delay_us(1);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#43: FILE: drivers/net/i40e/i40e_fdir.c:1305:
+     if (i >= (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US)) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (5, 10)
#43: FILE: drivers/net/i40e/i40e_fdir.c:1305:
+     if (i >= (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US)) {
           PMD_DRV_LOG(ERR, "Failed to program FDIR filter:"

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#50: FILE: drivers/net/i40e/i40e_fdir.c:1311:
+  uint32_t w;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#51: FILE: drivers/net/i40e/i40e_fdir.c:1312:
+     for (w = 0; w < (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US); w++) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (5, 11)
#51: FILE: drivers/net/i40e/i40e_fdir.c:1312:
+     for (w = 0; w < (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US); w++) {
+           if (i40e_check_fdir_programming_status(rxq) >= 0) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#52: FILE: drivers/net/i40e/i40e_fdir.c:1313:
+           if (i40e_check_fdir_programming_status(rxq) >= 0) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#52: FILE: drivers/net/i40e/i40e_fdir.c:1313:
+           if (i40e_check_fdir_programming_status(rxq) >= 0) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (11, 17)
#52: FILE: drivers/net/i40e/i40e_fdir.c:1313:
+           if (i40e_check_fdir_programming_status(rxq) >= 0) {
+                 break;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#52: FILE: drivers/net/i40e/i40e_fdir.c:1313:
+           if (i40e_check_fdir_programming_status(rxq) >= 0) {
+                 break;
+           }

ERROR:CODE_INDENT: code indent should use tabs where possible
#53: FILE: drivers/net/i40e/i40e_fdir.c:1314:
+                 break;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#53: FILE: drivers/net/i40e/i40e_fdir.c:1314:
+                 break;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#54: FILE: drivers/net/i40e/i40e_fdir.c:1315:
+           }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#54: FILE: drivers/net/i40e/i40e_fdir.c:1315:
+           }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#55: FILE: drivers/net/i40e/i40e_fdir.c:1316:
+           rte_delay_us(1);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#55: FILE: drivers/net/i40e/i40e_fdir.c:1316:
+           rte_delay_us(1);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#56: FILE: drivers/net/i40e/i40e_fdir.c:1317:
+     }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#60: FILE: drivers/net/i40e/i40e_fdir.c:1320:
+                           " programming status reported.");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#60: FILE: drivers/net/i40e/i40e_fdir.c:1320:
+                           " programming status reported.");$

ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#64: FILE: drivers/net/i40e/i40e_fdir.c:1322:
Disclaimer: This email and any files transmitted with it may contain confidential information intended for the addressee(s) only. The information is not to be surrendered or copied to unauthorized persons. If you have received this communication in error, please notify the sender immediately and delete this e-mail from your system.

total: 7 errors, 17 warnings, 0 checks, 35 lines checked