From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id C89D17CDE; Thu,  4 May 2017 17:33:45 +0200 (CEST)
In-Reply-To: <1493911874-5888-1-git-send-email-tomaszx.kulasek@intel.com>
References: <1493911874-5888-1-git-send-email-tomaszx.kulasek@intel.com>
To: test-report@dpdk.org
Cc: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Message-Id: <20170504153345.C89D17CDE@dpdk.org>
Date: Thu,  4 May 2017 17:33:45 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw24091 [PATCH RFC] cryptodev: make
	crypto session device independent
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 04 May 2017 15:33:46 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/24091

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#71: 
                                  SESSION MEMPOOL <---|---> DEVICE INSTANCES

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#275: FILE: lib/librte_cryptodev/rte_cryptodev.c:1278:
+	 *        for simplification */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#356: FILE: lib/librte_cryptodev/rte_cryptodev.c:1343:
+			//RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->session_get_size, -ENOTSUP);

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#614: FILE: lib/librte_cryptodev/rte_cryptodev.h:871:
+	uint32_t sess_mask;           /**< Mask containing which private data
+					   is set (faster free) */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#614: FILE: lib/librte_cryptodev/rte_cryptodev.h:871:
+					   is set (faster free) */

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#616: FILE: lib/librte_cryptodev/rte_cryptodev.h:873:
+	void *sess_private_data[32];  /**< Device type specific session private
+					   data */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#616: FILE: lib/librte_cryptodev/rte_cryptodev.h:873:
+					   data */

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#732: FILE: lib/librte_cryptodev/rte_cryptodev.h:958:
+#define rte_cryptodev_sym_sess_get_private_data(type, sess, id) \
+	(type *)get_session_private_data(sess, id)

total: 1 errors, 7 warnings, 501 lines checked