From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id AB80D2B9A; Wed, 17 May 2017 00:02:12 +0200 (CEST) In-Reply-To: <20170516220132.3813-1-ml@napatech.com> References: <20170516220132.3813-1-ml@napatech.com> To: test-report@dpdk.org Cc: Michael Lilja Message-Id: <20170516220212.AB80D2B9A@dpdk.org> Date: Wed, 17 May 2017 00:02:12 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw24327 [PATCH v3] net/i40e: Improved FDIR programming times X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 May 2017 22:02:12 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/24327 _coding style issues_ WARNING:LEADING_SPACE: please, no spaces at the start of a line #41: FILE: drivers/net/i40e/i40e_fdir.c:1299: + for (i = 0; i < (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US); i++) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15) #41: FILE: drivers/net/i40e/i40e_fdir.c:1299: + for (i = 0; i < (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US); i++) { if ((txdp->cmd_type_offset_bsz & ERROR:CODE_INDENT: code indent should use tabs where possible #45: FILE: drivers/net/i40e/i40e_fdir.c:1301: + rte_cpu_to_le_64(I40E_TXD_QW1_DTYPE_MASK)) ==$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #45: FILE: drivers/net/i40e/i40e_fdir.c:1301: + rte_cpu_to_le_64(I40E_TXD_QW1_DTYPE_MASK)) ==$ ERROR:CODE_INDENT: code indent should use tabs where possible #46: FILE: drivers/net/i40e/i40e_fdir.c:1302: + rte_cpu_to_le_64(I40E_TX_DESC_DTYPE_DESC_DONE))$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #46: FILE: drivers/net/i40e/i40e_fdir.c:1302: + rte_cpu_to_le_64(I40E_TX_DESC_DTYPE_DESC_DONE))$ ERROR:CODE_INDENT: code indent should use tabs where possible #48: FILE: drivers/net/i40e/i40e_fdir.c:1304: + rte_delay_us(1);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #48: FILE: drivers/net/i40e/i40e_fdir.c:1304: + rte_delay_us(1);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #51: FILE: drivers/net/i40e/i40e_fdir.c:1306: + if (i >= (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US)) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15) #51: FILE: drivers/net/i40e/i40e_fdir.c:1306: + if (i >= (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US)) { PMD_DRV_LOG(ERR, "Failed to program FDIR filter:" ERROR:CODE_INDENT: code indent should use tabs where possible #54: FILE: drivers/net/i40e/i40e_fdir.c:1308: + " time out to get DD on tx queue.");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #54: FILE: drivers/net/i40e/i40e_fdir.c:1308: + " time out to get DD on tx queue.");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #59: FILE: drivers/net/i40e/i40e_fdir.c:1312: + for (i = 0; i < (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US); i++) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15) #59: FILE: drivers/net/i40e/i40e_fdir.c:1312: + for (i = 0; i < (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US); i++) { + if (i40e_check_fdir_programming_status(rxq) >= 0) { ERROR:CODE_INDENT: code indent should use tabs where possible #60: FILE: drivers/net/i40e/i40e_fdir.c:1313: + if (i40e_check_fdir_programming_status(rxq) >= 0) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #60: FILE: drivers/net/i40e/i40e_fdir.c:1313: + if (i40e_check_fdir_programming_status(rxq) >= 0) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23) #60: FILE: drivers/net/i40e/i40e_fdir.c:1313: + if (i40e_check_fdir_programming_status(rxq) >= 0) { + break; WARNING:BRACES: braces {} are not necessary for single statement blocks #60: FILE: drivers/net/i40e/i40e_fdir.c:1313: + if (i40e_check_fdir_programming_status(rxq) >= 0) { + break; + } ERROR:CODE_INDENT: code indent should use tabs where possible #61: FILE: drivers/net/i40e/i40e_fdir.c:1314: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #61: FILE: drivers/net/i40e/i40e_fdir.c:1314: + break;$ ERROR:CODE_INDENT: code indent should use tabs where possible #62: FILE: drivers/net/i40e/i40e_fdir.c:1315: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #62: FILE: drivers/net/i40e/i40e_fdir.c:1315: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #63: FILE: drivers/net/i40e/i40e_fdir.c:1316: + rte_delay_us(1);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #63: FILE: drivers/net/i40e/i40e_fdir.c:1316: + rte_delay_us(1);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #64: FILE: drivers/net/i40e/i40e_fdir.c:1317: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #68: FILE: drivers/net/i40e/i40e_fdir.c:1320: + " programming status reported.");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #68: FILE: drivers/net/i40e/i40e_fdir.c:1320: + " programming status reported.");$ total: 9 errors, 18 warnings, 0 checks, 36 lines checked