From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 02F5C3256; Fri, 19 May 2017 19:13:49 +0200 (CEST)
In-Reply-To: <1495213972-109148-3-git-send-email-cristian.dumitrescu@intel.com>
References: <1495213972-109148-3-git-send-email-cristian.dumitrescu@intel.com>
To: test-report@dpdk.org
Cc: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Message-Id: <20170519171350.02F5C3256@dpdk.org>
Date: Fri, 19 May 2017 19:13:49 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw24412 [PATCH v4 2/2] ethdev: add
	traffic management API
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 19 May 2017 17:13:50 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/24412

_coding style issues_


WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#315: FILE: lib/librte_ether/rte_tm.c:61:
+			ENOSYS,

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#318: FILE: lib/librte_ether/rte_tm.c:64:
+			rte_strerror(ENOSYS));

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#325: FILE: lib/librte_ether/rte_tm.c:71:
+#define RTE_TM_FUNC(port_id, func)				\
+({							\
+	const struct rte_tm_ops *ops =			\
+		rte_tm_ops_get(port_id, error);		\
+	if (ops == NULL)					\
+		return -rte_errno;			\
+							\
+	if (ops->func == NULL)				\
+		return -rte_tm_error_set(error,		\
+			ENOSYS,				\
+			RTE_TM_ERROR_TYPE_UNSPECIFIED,	\
+			NULL,				\
+			rte_strerror(ENOSYS));		\
+							\
+	ops->func;					\
+})

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#334: FILE: lib/librte_ether/rte_tm.c:80:
+			ENOSYS,				\

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#337: FILE: lib/librte_ether/rte_tm.c:83:
+			rte_strerror(ENOSYS));		\

ERROR:TRAILING_WHITESPACE: trailing whitespace
#957: FILE: lib/librte_ether/rte_tm.h:249:
+^I$

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#1316: FILE: lib/librte_ether/rte_tm.h:608:
+			 * true for all the leaf nodes on this level. */

ERROR:SPACING: space required before the open brace '{'
#2118: FILE: lib/librte_ether/rte_tm.h:1410:
+	if (lid != level_id){

ERROR:SPACING: space required before the open brace '{'
#2119: FILE: lib/librte_ether/rte_tm.h:1411:
+		if (error){

total: 3 errors, 6 warnings, 2809 lines checked