* [dpdk-test-report] |WARNING| pw24619 [PATCH v4 09/20] net/dpaa2: add support for tail drop on queue
[not found] <1495781485-2236-10-git-send-email-hemant.agrawal@nxp.com>
@ 2017-05-26 6:52 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-05-26 6:52 UTC (permalink / raw)
To: test-report; +Cc: Hemant Agrawal
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/24619
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'cmd' - possible side-effects?
#251: FILE: drivers/net/dpaa2/mc/fsl_dpni_cmd.h:331:
+#define DPNI_CMD_GET_TAILDROP(cmd, cp, q_type, tc, q_index) \
+do { \
+ MC_CMD_OP(cmd, 0, 0, 8, enum dpni_congestion_point, cp); \
+ MC_CMD_OP(cmd, 0, 8, 8, enum dpni_queue_type, q_type); \
+ MC_CMD_OP(cmd, 0, 16, 8, uint8_t, tc); \
+ MC_CMD_OP(cmd, 0, 24, 8, uint8_t, q_index); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'cmd' - possible side-effects?
#259: FILE: drivers/net/dpaa2/mc/fsl_dpni_cmd.h:339:
+#define DPNI_RSP_GET_TAILDROP(cmd, taildrop) \
+do { \
+ MC_RSP_OP(cmd, 1, 0, 1, char, (taildrop)->enable); \
+ MC_RSP_OP(cmd, 1, 16, 8, enum dpni_congestion_unit, \
+ (taildrop)->units); \
+ MC_RSP_OP(cmd, 1, 32, 32, uint32_t, (taildrop)->threshold); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'taildrop' - possible side-effects?
#259: FILE: drivers/net/dpaa2/mc/fsl_dpni_cmd.h:339:
+#define DPNI_RSP_GET_TAILDROP(cmd, taildrop) \
+do { \
+ MC_RSP_OP(cmd, 1, 0, 1, char, (taildrop)->enable); \
+ MC_RSP_OP(cmd, 1, 16, 8, enum dpni_congestion_unit, \
+ (taildrop)->units); \
+ MC_RSP_OP(cmd, 1, 32, 32, uint32_t, (taildrop)->threshold); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'cmd' - possible side-effects?
#267: FILE: drivers/net/dpaa2/mc/fsl_dpni_cmd.h:347:
+#define DPNI_CMD_SET_TAILDROP(cmd, cp, q_type, tc, q_index, taildrop) \
+do { \
+ MC_CMD_OP(cmd, 0, 0, 8, enum dpni_congestion_point, cp); \
+ MC_CMD_OP(cmd, 0, 8, 8, enum dpni_queue_type, q_type); \
+ MC_CMD_OP(cmd, 0, 16, 8, uint8_t, tc); \
+ MC_CMD_OP(cmd, 0, 24, 8, uint8_t, q_index); \
+ MC_CMD_OP(cmd, 1, 0, 1, char, (taildrop)->enable); \
+ MC_CMD_OP(cmd, 1, 16, 8, enum dpni_congestion_unit, \
+ (taildrop)->units); \
+ MC_CMD_OP(cmd, 1, 32, 32, uint32_t, (taildrop)->threshold); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'taildrop' - possible side-effects?
#267: FILE: drivers/net/dpaa2/mc/fsl_dpni_cmd.h:347:
+#define DPNI_CMD_SET_TAILDROP(cmd, cp, q_type, tc, q_index, taildrop) \
+do { \
+ MC_CMD_OP(cmd, 0, 0, 8, enum dpni_congestion_point, cp); \
+ MC_CMD_OP(cmd, 0, 8, 8, enum dpni_queue_type, q_type); \
+ MC_CMD_OP(cmd, 0, 16, 8, uint8_t, tc); \
+ MC_CMD_OP(cmd, 0, 24, 8, uint8_t, q_index); \
+ MC_CMD_OP(cmd, 1, 0, 1, char, (taildrop)->enable); \
+ MC_CMD_OP(cmd, 1, 16, 8, enum dpni_congestion_unit, \
+ (taildrop)->units); \
+ MC_CMD_OP(cmd, 1, 32, 32, uint32_t, (taildrop)->threshold); \
+} while (0)
total: 0 errors, 0 warnings, 5 checks, 228 lines checked
^ permalink raw reply [flat|nested] only message in thread