From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id C6565A13C; Fri, 26 May 2017 08:53:06 +0200 (CEST)
In-Reply-To: <1495781485-2236-17-git-send-email-hemant.agrawal@nxp.com>
References: <1495781485-2236-17-git-send-email-hemant.agrawal@nxp.com>
To: test-report@dpdk.org
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
Message-Id: <20170526065306.C6565A13C@dpdk.org>
Date: Fri, 26 May 2017 08:53:06 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw24624 [PATCH v4 16/20] net/dpaa2:
	add support for flow control
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 26 May 2017 06:53:07 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/24624

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'cmd' - possible side-effects?
#275: FILE: drivers/net/dpaa2/mc/fsl_dpni_cmd.h:242:
+#define DPNI_CMD_SET_LINK_CFG(cmd, cfg) \
+do { \
+	MC_CMD_OP(cmd, 1, 0,  32, uint32_t, cfg->rate);\
+	MC_CMD_OP(cmd, 2, 0,  64, uint64_t, cfg->options);\
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'cfg' - possible side-effects?
#275: FILE: drivers/net/dpaa2/mc/fsl_dpni_cmd.h:242:
+#define DPNI_CMD_SET_LINK_CFG(cmd, cfg) \
+do { \
+	MC_CMD_OP(cmd, 1, 0,  32, uint32_t, cfg->rate);\
+	MC_CMD_OP(cmd, 2, 0,  64, uint64_t, cfg->options);\
+} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'cfg' may be better as '(cfg)' to avoid precedence issues
#275: FILE: drivers/net/dpaa2/mc/fsl_dpni_cmd.h:242:
+#define DPNI_CMD_SET_LINK_CFG(cmd, cfg) \
+do { \
+	MC_CMD_OP(cmd, 1, 0,  32, uint32_t, cfg->rate);\
+	MC_CMD_OP(cmd, 2, 0,  64, uint64_t, cfg->options);\
+} while (0)

total: 0 errors, 0 warnings, 3 checks, 235 lines checked