* [dpdk-test-report] |WARNING| pw24624 [PATCH v4 16/20] net/dpaa2: add support for flow control
[not found] <1495781485-2236-17-git-send-email-hemant.agrawal@nxp.com>
@ 2017-05-26 6:53 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-05-26 6:53 UTC (permalink / raw)
To: test-report; +Cc: Hemant Agrawal
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/24624
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'cmd' - possible side-effects?
#275: FILE: drivers/net/dpaa2/mc/fsl_dpni_cmd.h:242:
+#define DPNI_CMD_SET_LINK_CFG(cmd, cfg) \
+do { \
+ MC_CMD_OP(cmd, 1, 0, 32, uint32_t, cfg->rate);\
+ MC_CMD_OP(cmd, 2, 0, 64, uint64_t, cfg->options);\
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'cfg' - possible side-effects?
#275: FILE: drivers/net/dpaa2/mc/fsl_dpni_cmd.h:242:
+#define DPNI_CMD_SET_LINK_CFG(cmd, cfg) \
+do { \
+ MC_CMD_OP(cmd, 1, 0, 32, uint32_t, cfg->rate);\
+ MC_CMD_OP(cmd, 2, 0, 64, uint64_t, cfg->options);\
+} while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'cfg' may be better as '(cfg)' to avoid precedence issues
#275: FILE: drivers/net/dpaa2/mc/fsl_dpni_cmd.h:242:
+#define DPNI_CMD_SET_LINK_CFG(cmd, cfg) \
+do { \
+ MC_CMD_OP(cmd, 1, 0, 32, uint32_t, cfg->rate);\
+ MC_CMD_OP(cmd, 2, 0, 64, uint64_t, cfg->options);\
+} while (0)
total: 0 errors, 0 warnings, 3 checks, 235 lines checked
^ permalink raw reply [flat|nested] only message in thread