From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 32F64A106; Fri, 26 May 2017 16:42:48 +0200 (CEST)
In-Reply-To: <20170526143528.16533-2-danielx.t.mrzyglod@intel.com>
References: <20170526143528.16533-2-danielx.t.mrzyglod@intel.com>
To: test-report@dpdk.org
Cc: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Message-Id: <20170526144248.32F64A106@dpdk.org>
Date: Fri, 26 May 2017 16:42:48 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw24647 [PATCH 1/2] drivers/bonding:
	add other agg selection modes for mode4
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 26 May 2017 14:42:48 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/24647

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#16: 
This patch add support for setting additional aggregator modes for IEEE802.3AD

CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#252: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1370:
+	if (agg_selection == AGG_COUNT || agg_selection == AGG_BANDWIDTH
+			|| agg_selection == AGG_STABLE)

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#379: FILE: drivers/net/bonding/rte_eth_bond_8023ad.h:332:
+ * ^I0 on success, negative value otherwise$

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#478: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:2597:
+				&agg_mode) != 0) {
+

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#479: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:2598:
+
+		}

total: 0 errors, 2 warnings, 3 checks, 450 lines checked