From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Subject: [dpdk-test-report] |WARNING| pw24651 [PATCH 1/2] net/softnic: add softnic PMD for traffic management
Date: Fri, 26 May 2017 20:03:19 +0200 (CEST) [thread overview]
Message-ID: <20170526180319.A99A4A112@dpdk.org> (raw)
In-Reply-To: <20170526181149.44085-2-jasvinder.singh@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/24651
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#19:
path, softnic tx funtion enqueues the packets into QoS scheduler. The packets
WARNING:TYPO_SPELLING: 'funtion' may be misspelled - perhaps 'function'?
#19:
path, softnic tx funtion enqueues the packets into QoS scheduler. The packets
WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#210: FILE: drivers/net/softnic/rte_eth_softnic.c:52:
+static const char *pmd_valid_args[] = {
CHECK:SPACING: No space is necessary after a cast
#264: FILE: drivers/net/softnic/rte_eth_softnic.c:106:
+ dev->data->tx_queues[tx_queue_id] = (void *) p;
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#293: FILE: drivers/net/softnic/rte_eth_softnic.c:135:
+
+}
WARNING:RETURN_VOID: void function return statements are not generally useful
#308: FILE: drivers/net/softnic/rte_eth_softnic.c:150:
+ return;
+}
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#419: FILE: drivers/net/softnic/rte_eth_softnic.c:261:
+
+}
ERROR:CODE_INDENT: code indent should use tabs where possible
#570: FILE: drivers/net/softnic/rte_eth_softnic.c:412:
+ const char *value, void *extra_args)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#570: FILE: drivers/net/softnic/rte_eth_softnic.c:412:
+ const char *value, void *extra_args)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#580: FILE: drivers/net/softnic/rte_eth_softnic.c:422:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#580: FILE: drivers/net/softnic/rte_eth_softnic.c:422:
+ return 0;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#585: FILE: drivers/net/softnic/rte_eth_softnic.c:427:
+ const char *value, void *extra_args)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#585: FILE: drivers/net/softnic/rte_eth_softnic.c:427:
+ const char *value, void *extra_args)$
ERROR:SPACING: space required before the open parenthesis '('
#609: FILE: drivers/net/softnic/rte_eth_softnic.c:451:
+ if(!params)
CHECK:BRACES: braces {} should be used on all arms of this statement
#629: FILE: drivers/net/softnic/rte_eth_softnic.c:471:
+ if (rte_kvargs_count(kvlist, PMD_PARAM_IFACE_QUEUE) == 1) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#634: FILE: drivers/net/softnic/rte_eth_softnic.c:476:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#638: FILE: drivers/net/softnic/rte_eth_softnic.c:480:
+ if (rte_kvargs_count(kvlist, PMD_PARAM_DEQ_BSZ) == 1) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#643: FILE: drivers/net/softnic/rte_eth_softnic.c:485:
+ } else
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#845: FILE: drivers/net/softnic/rte_eth_softnic_default.c:41:
+#define UDEV(odev) \
+ ((struct pmd_internals *) ((odev)->data->dev_private))->udev
CHECK:SPACING: No space is necessary after a cast
#846: FILE: drivers/net/softnic/rte_eth_softnic_default.c:42:
+ ((struct pmd_internals *) ((odev)->data->dev_private))->udev
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#954: FILE: drivers/net/softnic/rte_eth_softnic_default.c:150:
+ struct rte_eth_xstat *stats, unsigned n)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#980: FILE: drivers/net/softnic/rte_eth_softnic_default.c:176:
+ struct rte_eth_xstat_name *xstats_names, unsigned size)
ERROR:CODE_INDENT: code indent should use tabs where possible
#1367: FILE: drivers/net/softnic/rte_eth_softnic_default.c:563:
+ struct timespec *timestamp, uint32_t flags)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1367: FILE: drivers/net/softnic/rte_eth_softnic_default.c:563:
+ struct timespec *timestamp, uint32_t flags)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#1442: FILE: drivers/net/softnic/rte_eth_softnic_default.c:638:
+ struct rte_eth_l2_tunnel_conf *l2_tunnel)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1442: FILE: drivers/net/softnic/rte_eth_softnic_default.c:638:
+ struct rte_eth_l2_tunnel_conf *l2_tunnel)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#1451: FILE: drivers/net/softnic/rte_eth_softnic_default.c:647:
+ struct rte_eth_l2_tunnel_conf *l2_tunnel,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1451: FILE: drivers/net/softnic/rte_eth_softnic_default.c:647:
+ struct rte_eth_l2_tunnel_conf *l2_tunnel,$
ERROR:SPACING: space required after that ',' (ctx:VxV)
#1457: FILE: drivers/net/softnic/rte_eth_softnic_default.c:653:
+ return dev->dev_ops->l2_tunnel_offload_set(dev,l2_tunnel, mask, en);
^
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1678: FILE: drivers/net/softnic/rte_eth_softnic_default.c:874:
+#define CHECK_AND_SET_NULL(o, u, func) \
+ if ((u)->func == NULL) \
+ (o)->func = NULL
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects?
#1678: FILE: drivers/net/softnic/rte_eth_softnic_default.c:874:
+#define CHECK_AND_SET_NULL(o, u, func) \
+ if ((u)->func == NULL) \
+ (o)->func = NULL
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'func' may be better as '(func)' to avoid precedence issues
#1678: FILE: drivers/net/softnic/rte_eth_softnic_default.c:874:
+#define CHECK_AND_SET_NULL(o, u, func) \
+ if ((u)->func == NULL) \
+ (o)->func = NULL
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1682: FILE: drivers/net/softnic/rte_eth_softnic_default.c:878:
+#define CHECK_AND_SET_NONNULL(o, u, func) \
+ if ((u)->func != NULL) \
+ (o)->func = (u)->func
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'u' - possible side-effects?
#1682: FILE: drivers/net/softnic/rte_eth_softnic_default.c:878:
+#define CHECK_AND_SET_NONNULL(o, u, func) \
+ if ((u)->func != NULL) \
+ (o)->func = (u)->func
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects?
#1682: FILE: drivers/net/softnic/rte_eth_softnic_default.c:878:
+#define CHECK_AND_SET_NONNULL(o, u, func) \
+ if ((u)->func != NULL) \
+ (o)->func = (u)->func
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'func' may be better as '(func)' to avoid precedence issues
#1682: FILE: drivers/net/softnic/rte_eth_softnic_default.c:878:
+#define CHECK_AND_SET_NONNULL(o, u, func) \
+ if ((u)->func != NULL) \
+ (o)->func = (u)->func
total: 11 errors, 12 warnings, 1923 lines checked
parent reply other threads:[~2017-05-26 18:03 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20170526181149.44085-2-jasvinder.singh@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170526180319.A99A4A112@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).