automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Subject: [dpdk-test-report] |WARNING| pw24714 [PATCH 3/4] cxgbe: remove rmb bottleneck in RX path
Date: Sat, 27 May 2017 07:48:51 +0200 (CEST)	[thread overview]
Message-ID: <20170527054851.380DE2BA7@dpdk.org> (raw)
In-Reply-To: <05be2ac96a860b3b6468fb86d68aad203ba364ea.1495856647.git.rahul.lakkireddy@chelsio.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/24714

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'head' - possible side-effects?
#37: FILE: drivers/net/cxgbe/sge.c:686:
+#define PIDXDIFF(head, tail, wrap) \
+	((tail) >= (head) ? (tail) - (head) : (wrap) - (head) + (tail))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tail' - possible side-effects?
#37: FILE: drivers/net/cxgbe/sge.c:686:
+#define PIDXDIFF(head, tail, wrap) \
+	((tail) >= (head) ? (tail) - (head) : (wrap) - (head) + (tail))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects?
#39: FILE: drivers/net/cxgbe/sge.c:688:
+#define P_IDXDIFF(q, idx) PIDXDIFF((q)->cidx, idx, (q)->size)

WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#129: FILE: drivers/net/cxgbe/sge.c:1494:
+				BUG_ON(!(len & F_RSPD_NEWBUF));

total: 0 errors, 1 warnings, 3 checks, 176 lines checked

           reply	other threads:[~2017-05-27  5:48 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <05be2ac96a860b3b6468fb86d68aad203ba364ea.1495856647.git.rahul.lakkireddy@chelsio.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170527054851.380DE2BA7@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=rahul.lakkireddy@chelsio.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).