From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id CA96F3798; Sat, 27 May 2017 12:23:55 +0200 (CEST)
In-Reply-To: <1495880735-1651-26-git-send-email-shreyansh.jain@nxp.com>
References: <1495880735-1651-26-git-send-email-shreyansh.jain@nxp.com>
To: test-report@dpdk.org
Cc: Shreyansh Jain <shreyansh.jain@nxp.com>
Message-Id: <20170527102355.CA96F3798@dpdk.org>
Date: Sat, 27 May 2017 12:23:55 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw24778 [PATCH RFC 25/39] net/dpaa:
	add support for Tx and Rx queue setup
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 27 May 2017 10:23:56 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/24778

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse '_mbuf' - possible side-effects?
#496: FILE: drivers/net/dpaa/dpaa_rxtx.c:77:
+#define DPAA_MBUF_TO_CONTIG_FD(_mbuf, _fd, _bpid) \
+	do { \
+		(_fd)->cmd = 0; \
+		(_fd)->opaque_addr = 0; \
+		(_fd)->opaque = QM_FD_CONTIG << DPAA_FD_FORMAT_SHIFT; \
+		(_fd)->opaque |= ((_mbuf)->data_off) << DPAA_FD_OFFSET_SHIFT; \
+		(_fd)->opaque |= (_mbuf)->pkt_len; \
+		(_fd)->addr = (_mbuf)->buf_physaddr; \
+		(_fd)->bpid = _bpid; \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_fd' - possible side-effects?
#496: FILE: drivers/net/dpaa/dpaa_rxtx.c:77:
+#define DPAA_MBUF_TO_CONTIG_FD(_mbuf, _fd, _bpid) \
+	do { \
+		(_fd)->cmd = 0; \
+		(_fd)->opaque_addr = 0; \
+		(_fd)->opaque = QM_FD_CONTIG << DPAA_FD_FORMAT_SHIFT; \
+		(_fd)->opaque |= ((_mbuf)->data_off) << DPAA_FD_OFFSET_SHIFT; \
+		(_fd)->opaque |= (_mbuf)->pkt_len; \
+		(_fd)->addr = (_mbuf)->buf_physaddr; \
+		(_fd)->bpid = _bpid; \
+	} while (0)

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#654: FILE: drivers/net/dpaa/dpaa_rxtx.c:235:
+						if (rte_mbuf_refcnt_read(mbuf) > 1) {

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#658: FILE: drivers/net/dpaa/dpaa_rxtx.c:239:
+						} else {

WARNING:LONG_LINE: line over 90 characters
#660: FILE: drivers/net/dpaa/dpaa_rxtx.c:241:
+								&fd_arr[loop], bp_info->bpid);

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#663: FILE: drivers/net/dpaa/dpaa_rxtx.c:244:
+						if (rte_mbuf_refcnt_read(mi) > 1) {

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#666: FILE: drivers/net/dpaa/dpaa_rxtx.c:247:
+						} else {

WARNING:LONG_LINE: line over 90 characters
#669: FILE: drivers/net/dpaa/dpaa_rxtx.c:250:
+								&fd_arr[loop], bp_info->bpid);

CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_buf' may be better as '(_buf)' to avoid precedence issues
#912: FILE: drivers/net/dpaa/dpaa_rxtx.h:175:
+#define GET_RX_PRS(_buf) \
+	(struct dpaa_eth_parse_results_t *)((uint8_t *)_buf + DEFAULT_RX_ICEOF)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_buf' may be better as '(_buf)' to avoid precedence issues
#915: FILE: drivers/net/dpaa/dpaa_rxtx.h:178:
+#define GET_TX_PRS(_buf) \
+	(struct dpaa_eth_parse_results_t *)((uint8_t *)_buf + DEFAULT_TX_ICEOF)

total: 0 errors, 6 warnings, 898 lines checked