From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Subject: [dpdk-test-report] |WARNING| pw24790 [PATCH 1/2] LACP control packet filtering offload
Date: Sat, 27 May 2017 13:30:57 +0200 (CEST) [thread overview]
Message-ID: <20170527113057.A5ED03777@dpdk.org> (raw)
In-Reply-To: <1495884464-3548-2-git-send-email-tomaszx.kulasek@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/24790
_coding style issues_
WARNING:TYPO_SPELLING: 'funtions' may be misspelled - perhaps 'functions'?
#14:
New API funtions implemented:
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#52: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:638:
+ * will happen in next function call. */
WARNING:LONG_LINE: line over 90 characters
#58: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:644:
+ if (rte_eth_tx_burst(slave_id, internals->mode4.slow_tx_queue, &lacp_pkt, 1) == 0) {
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#72: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:754:
+ struct rte_mbuf *lacp_pkt) {
+
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#74: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:756:
+ * function that queued packet */
CHECK:BRACES: Unbalanced braces around else statement
#84: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:766:
+ } else
WARNING:LONG_LINE_COMMENT: line over 90 characters
#106: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:842:
+ /* Find LACP packet to this port. Do not check subtype, it is done in
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#107: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:843:
+ * function that queued packet */
WARNING:LONG_LINE: line over 90 characters
#118: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:849:
+ if (rte_eth_rx_burst(slave_id, internals->mode4.slow_rx_queue, &lacp_pkt, 1) == 1)
WARNING:LONG_LINE: line over 90 characters
#119: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:850:
+ bond_mode_8023ad_handle_slow_pkt(internals, slave_id, lacp_pkt);
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#160: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1239:
} else if (likely(subtype == SLOW_SUBTYPE_LACP)) {
+
CHECK:BRACES: Unbalanced braces around else statement
#167: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1246:
+ } else
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#285: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:63:
+#define _htons(x) ((uint16_t)((((x) & 0x00ffU) << 8) | (((x) & 0xff00U) >> 8)))
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#339: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:184:
+ uint8_t slave_port) {
+
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#368: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:213:
+bond_ethdev_8023ad_flow_set(struct rte_eth_dev *bond_dev, uint8_t slave_port) {
+
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#412: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:257:
+ * bursting */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#455: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:300:
+ * bursting */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#477: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:322:
+ * slaves that are currently distributing. */
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#513: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:398:
while (j < num_rx_total) {
+
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#577: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1579:
+ * resources can't be free, so reinitialization is impossible. */
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#662: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1718:
+ (internals->mode4.slow_rx_queue > 0)) {
+
WARNING:LONG_LINE: line over 90 characters
#673: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1729:
+ internals->mode4.slow_flow[slave_eth_dev->data->port_id],
total: 0 errors, 13 warnings, 9 checks, 626 lines checked
parent reply other threads:[~2017-05-27 11:30 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1495884464-3548-2-git-send-email-tomaszx.kulasek@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170527113057.A5ED03777@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=tomaszx.kulasek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).