automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw24805 [PATCH RFC] Add hot plug event in rte eal interrupt and inplement it in i40e
       [not found] <1495986280-26207-1-git-send-email-jia.guo@intel.com>
@ 2017-05-28 15:53 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-05-28 15:53 UTC (permalink / raw)
  To: test-report; +Cc: Guo Jia

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/24805

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#18: 
For HW hotplug feature, we had already got upstream that removal event adding from 6wind as bellow.

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#67: FILE: drivers/net/i40e/i40e_ethdev.c:69:
+extern int hotplug_fd;

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#153: FILE: lib/librte_eal/linuxapp/eal/eal_interrupts.c:885:
+			}
+			else

WARNING:BRACES: braces {} are not necessary for single statement blocks
#243: FILE: lib/librte_eal/linuxapp/eal/eal_interrupts.c:1357:
+		if (!strncmp(action, "add", 3)) {
+			event->action = RTE_UEVENT_ADD;
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#246: FILE: lib/librte_eal/linuxapp/eal/eal_interrupts.c:1360:
+		if (!strncmp(action, "remove", 6)) {
+			event->action = RTE_UEVENT_REMOVE;
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#265: FILE: lib/librte_eal/linuxapp/eal/eal_interrupts.c:1379:
+	if (ret > 0) {
+		return parse_event(buf, uevent);
+	}

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#272: FILE: lib/librte_eal/linuxapp/eal/eal_interrupts.c:1386:
+			return 0;
+		} else {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#280: FILE: lib/librte_eal/linuxapp/eal/eal_interrupts.c:1394:
+	if (ret == 0) {
+		return -1;
+	}

total: 1 errors, 7 warnings, 253 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-05-28 15:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1495986280-26207-1-git-send-email-jia.guo@intel.com>
2017-05-28 15:53 ` [dpdk-test-report] |WARNING| pw24805 [PATCH RFC] Add hot plug event in rte eal interrupt and inplement it in i40e checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).