From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 4DBD758EC; Sun, 28 May 2017 17:53:05 +0200 (CEST)
In-Reply-To: <1495986280-26207-1-git-send-email-jia.guo@intel.com>
References: <1495986280-26207-1-git-send-email-jia.guo@intel.com>
To: test-report@dpdk.org
Cc: Guo Jia <jia.guo@intel.com>
Message-Id: <20170528155305.4DBD758EC@dpdk.org>
Date: Sun, 28 May 2017 17:53:05 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw24805 [PATCH RFC] Add hot plug event
	in rte eal interrupt and inplement it in i40e
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 28 May 2017 15:53:05 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/24805

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#18: 
For HW hotplug feature, we had already got upstream that removal event adding from 6wind as bellow.

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#67: FILE: drivers/net/i40e/i40e_ethdev.c:69:
+extern int hotplug_fd;

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#153: FILE: lib/librte_eal/linuxapp/eal/eal_interrupts.c:885:
+			}
+			else

WARNING:BRACES: braces {} are not necessary for single statement blocks
#243: FILE: lib/librte_eal/linuxapp/eal/eal_interrupts.c:1357:
+		if (!strncmp(action, "add", 3)) {
+			event->action = RTE_UEVENT_ADD;
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#246: FILE: lib/librte_eal/linuxapp/eal/eal_interrupts.c:1360:
+		if (!strncmp(action, "remove", 6)) {
+			event->action = RTE_UEVENT_REMOVE;
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#265: FILE: lib/librte_eal/linuxapp/eal/eal_interrupts.c:1379:
+	if (ret > 0) {
+		return parse_event(buf, uevent);
+	}

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#272: FILE: lib/librte_eal/linuxapp/eal/eal_interrupts.c:1386:
+			return 0;
+		} else {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#280: FILE: lib/librte_eal/linuxapp/eal/eal_interrupts.c:1394:
+	if (ret == 0) {
+		return -1;
+	}

total: 1 errors, 7 warnings, 253 lines checked