From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 8128B7D18; Thu, 1 Jun 2017 12:15:39 +0200 (CEST) In-Reply-To: <50fbd723942b7fe5a095247128ab53d717959e41.1496308649.git.gaetan.rivet@6wind.com> References: <50fbd723942b7fe5a095247128ab53d717959e41.1496308649.git.gaetan.rivet@6wind.com> To: test-report@dpdk.org Cc: Gaetan Rivet Message-Id: <20170601101539.8128B7D18@dpdk.org> Date: Thu, 1 Jun 2017 12:15:39 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw24979 [PATCH 8/8] bus/pci: introduce pci bus X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2017 10:15:39 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/24979 _coding style issues_ WARNING:AVOID_EXTERNS: externs should be avoided in .c files #326: FILE: drivers/bus/pci/bsd/rte_pci.c:90: +extern struct rte_pci_bus rte_pci_bus; WARNING:LONG_LINE: line over 90 characters #394: FILE: drivers/bus/pci/bsd/rte_pci.c:158: + "skipping ", loc->domain, loc->bus, loc->devid, loc->function); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #485: FILE: drivers/bus/pci/bsd/rte_pci.c:249: + unsigned i, max; WARNING:BRACES: braces {} are not necessary for single statement blocks #488: FILE: drivers/bus/pci/bsd/rte_pci.c:252: + if (dev == NULL) { + return -1; + } WARNING:LONG_LINE: line over 90 characters #550: FILE: drivers/bus/pci/bsd/rte_pci.c:314: + dev->mem_resource[i].addr = (void *)(bar.pbi_base & ~((uint64_t)0xf)); ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #560: FILE: drivers/bus/pci/bsd/rte_pci.c:324: + } + else { WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #598: FILE: drivers/bus/pci/bsd/rte_pci.c:362: + unsigned dev_count = 0; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #619: FILE: drivers/bus/pci/bsd/rte_pci.c:383: + unsigned i; ERROR:SPACING: space required before the open parenthesis '(' #631: FILE: drivers/bus/pci/bsd/rte_pci.c:395: + } while(conf_io.status == PCI_GETCONF_MORE_DEVS); WARNING:LONG_LINE_COMMENT: line over 90 characters #1047: FILE: drivers/bus/pci/include/rte_pci.h:133: + uint32_t class_id; /**< Class ID (class, subclass, pi) or RTE_CLASS_ANY_ID. */ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1095: FILE: drivers/bus/pci/include/rte_pci.h:181: +#define RTE_PCI_DEVICE(vend, dev) \ + RTE_CLASS_ANY_ID, \ + (vend), \ + (dev), \ + PCI_ANY_ID, \ + PCI_ANY_ID WARNING:LONG_LINE_COMMENT: line over 90 characters #1131: FILE: drivers/bus/pci/include/rte_pci.h:217: + uint32_t drv_flags; /**< Flags contolling handling of device. */ WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #1179: FILE: drivers/bus/pci/include/rte_pci.h:265: +#define GET_PCIADDR_FIELD(in, fd, lim, dlm) \ +do { \ + unsigned long val; \ + char *end; \ + errno = 0; \ + val = strtoul((in), &end, 16); \ + if (errno != 0 || end[0] != (dlm) || val > (lim)) \ + return -EINVAL; \ + (fd) = (typeof (fd))val; \ + (in) = end + 1; \ +} while(0) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1187: FILE: drivers/bus/pci/include/rte_pci.h:273: + (fd) = (typeof (fd))val; \ ERROR:SPACING: space required before the open parenthesis '(' #1189: FILE: drivers/bus/pci/include/rte_pci.h:275: +} while(0) WARNING:AVOID_EXTERNS: externs should be avoided in .c files #1677: FILE: drivers/bus/pci/linux/rte_pci.c:59: +extern struct rte_pci_bus rte_pci_bus; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1768: FILE: drivers/bus/pci/linux/rte_pci.c:150: + unsigned i = 0; ERROR:SPACING: spaces required around that '<' (ctx:VxV) #1830: FILE: drivers/bus/pci/linux/rte_pci.c:212: + for (i = 0; idomain, loc->bus, loc->devid, loc->function); WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #2848: FILE: drivers/bus/pci/linux/rte_pci_uio.c:397: + * uin16_t */ WARNING:LONG_LINE: line over 90 characters #3154: FILE: drivers/bus/pci/linux/rte_pci_vfio.c:130: + VFIO_GET_REGION_ADDR(VFIO_PCI_CONFIG_REGION_INDEX) + WARNING:LONG_LINE: line over 90 characters #3171: FILE: drivers/bus/pci/linux/rte_pci_vfio.c:147: + VFIO_GET_REGION_ADDR(VFIO_PCI_CONFIG_REGION_INDEX) + WARNING:LONG_LINE: line over 90 characters #3180: FILE: drivers/bus/pci/linux/rte_pci_vfio.c:156: + VFIO_GET_REGION_ADDR(VFIO_PCI_CONFIG_REGION_INDEX) + WARNING:TYPO_SPELLING: 'overriden' may be misspelled - perhaps 'overridden'? #3241: FILE: drivers/bus/pci/linux/rte_pci_vfio.c:217: + * overriden from the command line WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #3281: FILE: drivers/bus/pci/linux/rte_pci_vfio.c:257: + * specified interrupt type, otherwise continue */ WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return #3287: FILE: drivers/bus/pci/linux/rte_pci_vfio.c:263: + return -1; + } else WARNING:LONG_LINE: line over 90 characters #3340: FILE: drivers/bus/pci/linux/rte_pci_vfio.c:316: + struct mapped_pci_res_list *vfio_res_list = RTE_TAILQ_CAST(rte_vfio_tailq.head, mapped_pci_res_list); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3354: FILE: drivers/bus/pci/linux/rte_pci_vfio.c:330: + if ((ret = vfio_setup_device(pci_get_sysfs_path(), pci_addr, WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #3359: FILE: drivers/bus/pci/linux/rte_pci_vfio.c:335: + * easily mmap it when using VFIO) */ WARNING:LONG_LINE: line over 90 characters #3416: FILE: drivers/bus/pci/linux/rte_pci_vfio.c:392: + "error %i (%s) ", pci_addr, errno, strerror(errno)); WARNING:LONG_LINE: line over 90 characters #3542: FILE: drivers/bus/pci/linux/rte_pci_vfio.c:518: + RTE_LOG(ERR, EAL, " %s error setting up interrupts! ", pci_addr); WARNING:LONG_LINE: line over 90 characters #3550: FILE: drivers/bus/pci/linux/rte_pci_vfio.c:526: + RTE_LOG(ERR, EAL, " %s cannot set up bus mastering! ", pci_addr); WARNING:AVOID_EXTERNS: externs should be avoided in .c files #4395: FILE: drivers/bus/pci/rte_pci_common.c:88: +extern struct rte_pci_bus rte_pci_bus; total: 9 errors, 33 warnings, 5055 lines checked