From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id B78F17D9E; Fri,  2 Jun 2017 08:46:11 +0200 (CEST)
In-Reply-To: <1496385391-12445-6-git-send-email-wei.zhao1@intel.com>
References: <1496385391-12445-6-git-send-email-wei.zhao1@intel.com>
To: test-report@dpdk.org
Cc: zhao wei <wei.zhao1@intel.com>
Message-Id: <20170602064611.B78F17D9E@dpdk.org>
Date: Fri,  2 Jun 2017 08:46:11 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw25023 [PATCH v2 05/11] net/e1000:
	parse n-tuple filter
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Jun 2017 06:46:12 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25023

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#47: FILE: drivers/net/e1000/e1000_ethdev.h:146:
+#define MAC_TYPE_FILTER_SUP(type)    do {\
+	if ((type) != e1000_82580 && (type) != e1000_i350 &&\
+		(type) != e1000_82576 && (type) != e1000_i210 &&\
+		(type) != e1000_i211)\
+		return -ENOTSUP;\
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'item' - possible side-effects?
#172: FILE: drivers/net/e1000/igb_flow.c:62:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\
+	do {		\
+		item = pattern + index;\
+		while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+		index++;				\
+		item = pattern + index;		\
+		}						\
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pattern' - possible side-effects?
#172: FILE: drivers/net/e1000/igb_flow.c:62:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\
+	do {		\
+		item = pattern + index;\
+		while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+		index++;				\
+		item = pattern + index;		\
+		}						\
+	} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'pattern' may be better as '(pattern)' to avoid precedence issues
#172: FILE: drivers/net/e1000/igb_flow.c:62:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\
+	do {		\
+		item = pattern + index;\
+		while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+		index++;				\
+		item = pattern + index;		\
+		}						\
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#172: FILE: drivers/net/e1000/igb_flow.c:62:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\
+	do {		\
+		item = pattern + index;\
+		while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+		index++;				\
+		item = pattern + index;		\
+		}						\
+	} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'index' may be better as '(index)' to avoid precedence issues
#172: FILE: drivers/net/e1000/igb_flow.c:62:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\
+	do {		\
+		item = pattern + index;\
+		while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+		index++;				\
+		item = pattern + index;		\
+		}						\
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'act' - possible side-effects?
#181: FILE: drivers/net/e1000/igb_flow.c:71:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)\
+	do {								\
+		act = actions + index;					\
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+		index++;					\
+		act = actions + index;				\
+		}							\
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'actions' - possible side-effects?
#181: FILE: drivers/net/e1000/igb_flow.c:71:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)\
+	do {								\
+		act = actions + index;					\
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+		index++;					\
+		act = actions + index;				\
+		}							\
+	} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'actions' may be better as '(actions)' to avoid precedence issues
#181: FILE: drivers/net/e1000/igb_flow.c:71:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)\
+	do {								\
+		act = actions + index;					\
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+		index++;					\
+		act = actions + index;				\
+		}							\
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#181: FILE: drivers/net/e1000/igb_flow.c:71:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)\
+	do {								\
+		act = actions + index;					\
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+		index++;					\
+		act = actions + index;				\
+		}							\
+	} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'index' may be better as '(index)' to avoid precedence issues
#181: FILE: drivers/net/e1000/igb_flow.c:71:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)\
+	do {								\
+		act = actions + index;					\
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+		index++;					\
+		act = actions + index;				\
+		}							\
+	} while (0)

WARNING:TABSTOP: Statements should start on a tabstop
#297: FILE: drivers/net/e1000/igb_flow.c:187:
+			  return -rte_errno;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#321: FILE: drivers/net/e1000/igb_flow.c:211:
+	if (ipv4_mask->hdr.version_ihl ||
[...]
+			rte_flow_error_set(error,

WARNING:MISSING_EOF_NEWLINE: adding a line without newline at end of file
#615: FILE: drivers/net/e1000/igb_flow.c:505:
+};

total: 0 errors, 4 warnings, 10 checks, 565 lines checked