automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw25088 [PATCH v2 1/4] net/i40e: support flexible payload parsing for FDIR
       [not found] <1496822996-26398-2-git-send-email-beilei.xing@intel.com>
@ 2017-06-07  8:14 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-06-07  8:14 UTC (permalink / raw)
  To: test-report; +Cc: Beilei Xing

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25088

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dst_offset' - possible side-effects?
#38: FILE: drivers/net/i40e/i40e_ethdev.h:439:
+#define MK_FLX_PIT(src_offset, fsize, dst_offset) ( \
+	(((src_offset) << I40E_PRTQF_FLX_PIT_SOURCE_OFF_SHIFT) & \
+		I40E_PRTQF_FLX_PIT_SOURCE_OFF_MASK) | \
+	(((fsize) << I40E_PRTQF_FLX_PIT_FSIZE_SHIFT) & \
+			I40E_PRTQF_FLX_PIT_FSIZE_MASK) | \
+	((((dst_offset) == NONUSE_FLX_PIT_DEST_OFF ? \
+			NONUSE_FLX_PIT_DEST_OFF : \
+			((dst_offset) + I40E_FLX_OFFSET_IN_FIELD_VECTOR)) << \
+			I40E_PRTQF_FLX_PIT_DEST_OFF_SHIFT) & \
+			I40E_PRTQF_FLX_PIT_DEST_OFF_MASK))

CHECK:BRACES: braces {} should be used on all arms of this statement
#455: FILE: drivers/net/i40e/i40e_flow.c:1356:
+			if (ret < 0) {
[...]
+			} else if (ret > 0)
[...]

CHECK:BRACES: braces {} should be used on all arms of this statement
#482: FILE: drivers/net/i40e/i40e_flow.c:1411:
+	if (ret == -1) {
[...]
+	} else if (ret == -2) {
[...]
+	} else if (ret > 0)
[...]

total: 0 errors, 0 warnings, 3 checks, 454 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-06-07  8:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1496822996-26398-2-git-send-email-beilei.xing@intel.com>
2017-06-07  8:14 ` [dpdk-test-report] |WARNING| pw25088 [PATCH v2 1/4] net/i40e: support flexible payload parsing for FDIR checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).