* [dpdk-test-report] |WARNING| pw25208 [PATCH v3 05/11] net/e1000: parse n-tuple filter
[not found] <1496977908-2149-6-git-send-email-wei.zhao1@intel.com>
@ 2017-06-09 3:22 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-06-09 3:22 UTC (permalink / raw)
To: test-report; +Cc: zhao wei
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25208
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#47: FILE: drivers/net/e1000/e1000_ethdev.h:146:
+#define MAC_TYPE_FILTER_SUP(type) do {\
+ if ((type) != e1000_82580 && (type) != e1000_i350 &&\
+ (type) != e1000_82576 && (type) != e1000_i210 &&\
+ (type) != e1000_i211)\
+ return -ENOTSUP;\
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'item' - possible side-effects?
#172: FILE: drivers/net/e1000/igb_flow.c:62:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\
+ do { \
+ item = pattern + index;\
+ while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+ index++; \
+ item = pattern + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pattern' - possible side-effects?
#172: FILE: drivers/net/e1000/igb_flow.c:62:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\
+ do { \
+ item = pattern + index;\
+ while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+ index++; \
+ item = pattern + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'pattern' may be better as '(pattern)' to avoid precedence issues
#172: FILE: drivers/net/e1000/igb_flow.c:62:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\
+ do { \
+ item = pattern + index;\
+ while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+ index++; \
+ item = pattern + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#172: FILE: drivers/net/e1000/igb_flow.c:62:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\
+ do { \
+ item = pattern + index;\
+ while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+ index++; \
+ item = pattern + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'index' may be better as '(index)' to avoid precedence issues
#172: FILE: drivers/net/e1000/igb_flow.c:62:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\
+ do { \
+ item = pattern + index;\
+ while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+ index++; \
+ item = pattern + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'act' - possible side-effects?
#181: FILE: drivers/net/e1000/igb_flow.c:71:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)\
+ do { \
+ act = actions + index; \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+ index++; \
+ act = actions + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'actions' - possible side-effects?
#181: FILE: drivers/net/e1000/igb_flow.c:71:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)\
+ do { \
+ act = actions + index; \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+ index++; \
+ act = actions + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'actions' may be better as '(actions)' to avoid precedence issues
#181: FILE: drivers/net/e1000/igb_flow.c:71:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)\
+ do { \
+ act = actions + index; \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+ index++; \
+ act = actions + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#181: FILE: drivers/net/e1000/igb_flow.c:71:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)\
+ do { \
+ act = actions + index; \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+ index++; \
+ act = actions + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'index' may be better as '(index)' to avoid precedence issues
#181: FILE: drivers/net/e1000/igb_flow.c:71:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)\
+ do { \
+ act = actions + index; \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+ index++; \
+ act = actions + index; \
+ } \
+ } while (0)
WARNING:TABSTOP: Statements should start on a tabstop
#297: FILE: drivers/net/e1000/igb_flow.c:187:
+ return -rte_errno;
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#321: FILE: drivers/net/e1000/igb_flow.c:211:
+ if (ipv4_mask->hdr.version_ihl ||
[...]
+ rte_flow_error_set(error,
WARNING:MISSING_EOF_NEWLINE: adding a line without newline at end of file
#624: FILE: drivers/net/e1000/igb_flow.c:514:
+};
total: 0 errors, 4 warnings, 10 checks, 574 lines checked
^ permalink raw reply [flat|nested] only message in thread