From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Beilei Xing <beilei.xing@intel.com>
Subject: [dpdk-test-report] |WARNING| pw25218 [PATCH v3 1/4] net/i40e: support flexible payload parsing for FDIR
Date: Fri, 9 Jun 2017 10:26:27 +0200 (CEST) [thread overview]
Message-ID: <20170609082627.9E87758CD@dpdk.org> (raw)
In-Reply-To: <1496996483-24620-2-git-send-email-beilei.xing@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25218
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dst_offset' - possible side-effects?
#39: FILE: drivers/net/i40e/i40e_ethdev.h:439:
+#define MK_FLX_PIT(src_offset, fsize, dst_offset) ( \
+ (((src_offset) << I40E_PRTQF_FLX_PIT_SOURCE_OFF_SHIFT) & \
+ I40E_PRTQF_FLX_PIT_SOURCE_OFF_MASK) | \
+ (((fsize) << I40E_PRTQF_FLX_PIT_FSIZE_SHIFT) & \
+ I40E_PRTQF_FLX_PIT_FSIZE_MASK) | \
+ ((((dst_offset) == NONUSE_FLX_PIT_DEST_OFF ? \
+ NONUSE_FLX_PIT_DEST_OFF : \
+ ((dst_offset) + I40E_FLX_OFFSET_IN_FIELD_VECTOR)) << \
+ I40E_PRTQF_FLX_PIT_DEST_OFF_SHIFT) & \
+ I40E_PRTQF_FLX_PIT_DEST_OFF_MASK))
CHECK:BRACES: braces {} should be used on all arms of this statement
#457: FILE: drivers/net/i40e/i40e_flow.c:1357:
+ if (ret < 0) {
[...]
+ } else if (ret > 0)
[...]
CHECK:BRACES: braces {} should be used on all arms of this statement
#484: FILE: drivers/net/i40e/i40e_flow.c:1412:
+ if (ret == -1) {
[...]
+ } else if (ret == -2) {
[...]
+ } else if (ret > 0)
[...]
total: 0 errors, 0 warnings, 3 checks, 455 lines checked
parent reply other threads:[~2017-06-09 8:26 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1496996483-24620-2-git-send-email-beilei.xing@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609082627.9E87758CD@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=beilei.xing@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).