From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 9E87758CD; Fri,  9 Jun 2017 10:26:27 +0200 (CEST)
In-Reply-To: <1496996483-24620-2-git-send-email-beilei.xing@intel.com>
References: <1496996483-24620-2-git-send-email-beilei.xing@intel.com>
To: test-report@dpdk.org
Cc: Beilei Xing <beilei.xing@intel.com>
Message-Id: <20170609082627.9E87758CD@dpdk.org>
Date: Fri,  9 Jun 2017 10:26:27 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw25218 [PATCH v3 1/4] net/i40e:
	support flexible payload parsing for FDIR
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Jun 2017 08:26:27 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25218

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dst_offset' - possible side-effects?
#39: FILE: drivers/net/i40e/i40e_ethdev.h:439:
+#define MK_FLX_PIT(src_offset, fsize, dst_offset) ( \
+	(((src_offset) << I40E_PRTQF_FLX_PIT_SOURCE_OFF_SHIFT) & \
+		I40E_PRTQF_FLX_PIT_SOURCE_OFF_MASK) | \
+	(((fsize) << I40E_PRTQF_FLX_PIT_FSIZE_SHIFT) & \
+			I40E_PRTQF_FLX_PIT_FSIZE_MASK) | \
+	((((dst_offset) == NONUSE_FLX_PIT_DEST_OFF ? \
+			NONUSE_FLX_PIT_DEST_OFF : \
+			((dst_offset) + I40E_FLX_OFFSET_IN_FIELD_VECTOR)) << \
+			I40E_PRTQF_FLX_PIT_DEST_OFF_SHIFT) & \
+			I40E_PRTQF_FLX_PIT_DEST_OFF_MASK))

CHECK:BRACES: braces {} should be used on all arms of this statement
#457: FILE: drivers/net/i40e/i40e_flow.c:1357:
+			if (ret < 0) {
[...]
+			} else if (ret > 0)
[...]

CHECK:BRACES: braces {} should be used on all arms of this statement
#484: FILE: drivers/net/i40e/i40e_flow.c:1412:
+	if (ret == -1) {
[...]
+	} else if (ret == -2) {
[...]
+	} else if (ret > 0)
[...]

total: 0 errors, 0 warnings, 3 checks, 455 lines checked