automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Subject: [dpdk-test-report] |WARNING| pw25234 [PATCH v5 2/2] ethdev: add traffic management API
Date: Fri,  9 Jun 2017 18:52:51 +0200 (CEST)	[thread overview]
Message-ID: <20170609165251.9E0645398@dpdk.org> (raw)
In-Reply-To: <1497027075-31738-3-git-send-email-cristian.dumitrescu@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25234

_coding style issues_


WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#333: FILE: lib/librte_ether/rte_tm.c:61:
+			ENOSYS,

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#336: FILE: lib/librte_ether/rte_tm.c:64:
+			rte_strerror(ENOSYS));

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#343: FILE: lib/librte_ether/rte_tm.c:71:
+#define RTE_TM_FUNC(port_id, func)				\
+({							\
+	const struct rte_tm_ops *ops =			\
+		rte_tm_ops_get(port_id, error);		\
+	if (ops == NULL)					\
+		return -rte_errno;			\
+							\
+	if (ops->func == NULL)				\
+		return -rte_tm_error_set(error,		\
+			ENOSYS,				\
+			RTE_TM_ERROR_TYPE_UNSPECIFIED,	\
+			NULL,				\
+			rte_strerror(ENOSYS));		\
+							\
+	ops->func;					\
+})

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#352: FILE: lib/librte_ether/rte_tm.c:80:
+			ENOSYS,				\

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#355: FILE: lib/librte_ether/rte_tm.c:83:
+			rte_strerror(ENOSYS));		\

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#2409: FILE: lib/librte_ether/rte_tm.h:1693:
+ *   0 on success, non-zero error code otherwise.
+  *

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#2410: FILE: lib/librte_ether/rte_tm.h:1694:
+  *
+ * @see struct rte_tm_capabilities

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#2411: FILE: lib/librte_ether/rte_tm.h:1695:
+ * @see struct rte_tm_capabilities
+*/

total: 0 errors, 8 warnings, 2769 lines checked

           reply	other threads:[~2017-06-09 16:52 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1497027075-31738-3-git-send-email-cristian.dumitrescu@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170609165251.9E0645398@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=cristian.dumitrescu@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).