From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 9E0645398; Fri,  9 Jun 2017 18:52:51 +0200 (CEST)
In-Reply-To: <1497027075-31738-3-git-send-email-cristian.dumitrescu@intel.com>
References: <1497027075-31738-3-git-send-email-cristian.dumitrescu@intel.com>
To: test-report@dpdk.org
Cc: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Message-Id: <20170609165251.9E0645398@dpdk.org>
Date: Fri,  9 Jun 2017 18:52:51 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw25234 [PATCH v5 2/2] ethdev: add
	traffic management API
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Jun 2017 16:52:51 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25234

_coding style issues_


WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#333: FILE: lib/librte_ether/rte_tm.c:61:
+			ENOSYS,

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#336: FILE: lib/librte_ether/rte_tm.c:64:
+			rte_strerror(ENOSYS));

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#343: FILE: lib/librte_ether/rte_tm.c:71:
+#define RTE_TM_FUNC(port_id, func)				\
+({							\
+	const struct rte_tm_ops *ops =			\
+		rte_tm_ops_get(port_id, error);		\
+	if (ops == NULL)					\
+		return -rte_errno;			\
+							\
+	if (ops->func == NULL)				\
+		return -rte_tm_error_set(error,		\
+			ENOSYS,				\
+			RTE_TM_ERROR_TYPE_UNSPECIFIED,	\
+			NULL,				\
+			rte_strerror(ENOSYS));		\
+							\
+	ops->func;					\
+})

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#352: FILE: lib/librte_ether/rte_tm.c:80:
+			ENOSYS,				\

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#355: FILE: lib/librte_ether/rte_tm.c:83:
+			rte_strerror(ENOSYS));		\

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#2409: FILE: lib/librte_ether/rte_tm.h:1693:
+ *   0 on success, non-zero error code otherwise.
+  *

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#2410: FILE: lib/librte_ether/rte_tm.h:1694:
+  *
+ * @see struct rte_tm_capabilities

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#2411: FILE: lib/librte_ether/rte_tm.h:1695:
+ * @see struct rte_tm_capabilities
+*/

total: 0 errors, 8 warnings, 2769 lines checked