From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 532ED2BC3; Mon, 12 Jun 2017 08:41:29 +0200 (CEST) In-Reply-To: <1497249016-33565-7-git-send-email-wei.zhao1@intel.com> References: <1497249016-33565-7-git-send-email-wei.zhao1@intel.com> To: test-report@dpdk.org Cc: zhao wei Message-Id: <20170612064129.532ED2BC3@dpdk.org> Date: Mon, 12 Jun 2017 08:41:29 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw25248 [PATCH v4 05/11] net/e1000: parse n-tuple filter X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jun 2017 06:41:29 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/25248 _coding style issues_ WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #47: FILE: drivers/net/e1000/e1000_ethdev.h:146: +#define MAC_TYPE_FILTER_SUP(type) do {\ + if ((type) != e1000_82580 && (type) != e1000_i350 &&\ + (type) != e1000_82576 && (type) != e1000_i210 &&\ + (type) != e1000_i211)\ + return -ENOTSUP;\ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'item' - possible side-effects? #172: FILE: drivers/net/e1000/igb_flow.c:62: +#define NEXT_ITEM_OF_PATTERN(item, pattern, index) \ + do { \ + item = (pattern) + (index); \ + while (item->type == RTE_FLOW_ITEM_TYPE_VOID) { \ + (index)++; \ + item = (pattern) + (index); \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pattern' - possible side-effects? #172: FILE: drivers/net/e1000/igb_flow.c:62: +#define NEXT_ITEM_OF_PATTERN(item, pattern, index) \ + do { \ + item = (pattern) + (index); \ + while (item->type == RTE_FLOW_ITEM_TYPE_VOID) { \ + (index)++; \ + item = (pattern) + (index); \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects? #172: FILE: drivers/net/e1000/igb_flow.c:62: +#define NEXT_ITEM_OF_PATTERN(item, pattern, index) \ + do { \ + item = (pattern) + (index); \ + while (item->type == RTE_FLOW_ITEM_TYPE_VOID) { \ + (index)++; \ + item = (pattern) + (index); \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'act' - possible side-effects? #181: FILE: drivers/net/e1000/igb_flow.c:71: +#define NEXT_ITEM_OF_ACTION(act, actions, index) \ + do { \ + act = (actions) + (index); \ + while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\ + (index)++; \ + act = (actions) + (index); \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'actions' - possible side-effects? #181: FILE: drivers/net/e1000/igb_flow.c:71: +#define NEXT_ITEM_OF_ACTION(act, actions, index) \ + do { \ + act = (actions) + (index); \ + while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\ + (index)++; \ + act = (actions) + (index); \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects? #181: FILE: drivers/net/e1000/igb_flow.c:71: +#define NEXT_ITEM_OF_ACTION(act, actions, index) \ + do { \ + act = (actions) + (index); \ + while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\ + (index)++; \ + act = (actions) + (index); \ + } \ + } while (0) total: 0 errors, 1 warnings, 6 checks, 575 lines checked