[dpdk-test-report] |WARNING| pw25350 [PATCH v2 1/6] net/vmxnet3: retain counters on restart

automatic DPDK test reports
 help / color / mirror / Atom feed

From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Chas Williams <ciwillia@brocade.com>
Subject: [dpdk-test-report] |WARNING| pw25350 [PATCH v2 1/6] net/vmxnet3: retain counters on restart
Date: Thu, 15 Jun 2017 14:17:51 +0200 (CEST)	[thread overview]
Message-ID: <20170615121751.2AD9C5583@dpdk.org> (raw)
In-Reply-To: <1497528973-16330-2-git-send-email-ciwillia@brocade.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25350

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <UPT1_TxStats>
#70: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:832:
+			struct UPT1_TxStats *res)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'h' - possible side-effects?
#72: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:834:
+#define VMXNET3_UPDATE_TX_STAT(h, i, f, r)		\
+		((r)->f = (h)->tqd_start[(i)].stats.f +	\
+			(h)->saved_tx_stats[(i)].f)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects?
#72: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:834:
+#define VMXNET3_UPDATE_TX_STAT(h, i, f, r)		\
+		((r)->f = (h)->tqd_start[(i)].stats.f +	\
+			(h)->saved_tx_stats[(i)].f)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'f' - possible side-effects?
#72: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:834:
+#define VMXNET3_UPDATE_TX_STAT(h, i, f, r)		\
+		((r)->f = (h)->tqd_start[(i)].stats.f +	\
+			(h)->saved_tx_stats[(i)].f)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'f' may be better as '(f)' to avoid precedence issues
#72: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:834:
+#define VMXNET3_UPDATE_TX_STAT(h, i, f, r)		\
+		((r)->f = (h)->tqd_start[(i)].stats.f +	\
+			(h)->saved_tx_stats[(i)].f)

CHECK:CAMELCASE: Avoid CamelCase: <ucastPktsTxOK>
#76: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:838:
+	VMXNET3_UPDATE_TX_STAT(hw, q, ucastPktsTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <mcastPktsTxOK>
#77: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:839:
+	VMXNET3_UPDATE_TX_STAT(hw, q, mcastPktsTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <bcastPktsTxOK>
#78: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:840:
+	VMXNET3_UPDATE_TX_STAT(hw, q, bcastPktsTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <ucastBytesTxOK>
#79: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:841:
+	VMXNET3_UPDATE_TX_STAT(hw, q, ucastBytesTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <mcastBytesTxOK>
#80: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:842:
+	VMXNET3_UPDATE_TX_STAT(hw, q, mcastBytesTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <bcastBytesTxOK>
#81: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:843:
+	VMXNET3_UPDATE_TX_STAT(hw, q, bcastBytesTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <pktsTxError>
#82: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:844:
+	VMXNET3_UPDATE_TX_STAT(hw, q, pktsTxError, res);

CHECK:CAMELCASE: Avoid CamelCase: <pktsTxDiscard>
#83: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:845:
+	VMXNET3_UPDATE_TX_STAT(hw, q, pktsTxDiscard, res);

CHECK:CAMELCASE: Avoid CamelCase: <UPT1_RxStats>
#90: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:852:
+			struct UPT1_RxStats *res)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'h' - possible side-effects?
#92: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:854:
+#define VMXNET3_UPDATE_RX_STAT(h, i, f, r)		\
+		((r)->f = (h)->rqd_start[(i)].stats.f +	\
+			(h)->saved_rx_stats[(i)].f)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects?
#92: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:854:
+#define VMXNET3_UPDATE_RX_STAT(h, i, f, r)		\
+		((r)->f = (h)->rqd_start[(i)].stats.f +	\
+			(h)->saved_rx_stats[(i)].f)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'f' - possible side-effects?
#92: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:854:
+#define VMXNET3_UPDATE_RX_STAT(h, i, f, r)		\
+		((r)->f = (h)->rqd_start[(i)].stats.f +	\
+			(h)->saved_rx_stats[(i)].f)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'f' may be better as '(f)' to avoid precedence issues
#92: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:854:
+#define VMXNET3_UPDATE_RX_STAT(h, i, f, r)		\
+		((r)->f = (h)->rqd_start[(i)].stats.f +	\
+			(h)->saved_rx_stats[(i)].f)

CHECK:CAMELCASE: Avoid CamelCase: <ucastPktsRxOK>
#96: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:858:
+	VMXNET3_UPDATE_RX_STAT(hw, q, ucastPktsRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <mcastPktsRxOK>
#97: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:859:
+	VMXNET3_UPDATE_RX_STAT(hw, q, mcastPktsRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <bcastPktsRxOK>
#98: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:860:
+	VMXNET3_UPDATE_RX_STAT(hw, q, bcastPktsRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <ucastBytesRxOK>
#99: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:861:
+	VMXNET3_UPDATE_RX_STAT(hw, q, ucastBytesRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <mcastBytesRxOK>
#100: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:862:
+	VMXNET3_UPDATE_RX_STAT(hw, q, mcastBytesRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <bcastBytesRxOK>
#101: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:863:
+	VMXNET3_UPDATE_RX_STAT(hw, q, bcastBytesRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <pktsRxError>
#102: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:864:
+	VMXNET3_UPDATE_RX_STAT(hw, q, pktsRxError, res);

CHECK:CAMELCASE: Avoid CamelCase: <pktsRxOutOfBuf>
#103: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:865:
+	VMXNET3_UPDATE_RX_STAT(hw, q, pktsRxOutOfBuf, res);

CHECK:CAMELCASE: Avoid CamelCase: <txStats>
#128: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:890:
+	struct UPT1_TxStats txStats;

CHECK:CAMELCASE: Avoid CamelCase: <rxStats>
#129: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:891:
+	struct UPT1_RxStats rxStats;

total: 0 errors, 0 warnings, 28 checks, 157 lines checked

          parent reply	other threads:[~2017-06-15 12:17 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1497528973-16330-2-git-send-email-ciwillia@brocade.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170615121751.2AD9C5583@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=ciwillia@brocade.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).