From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 2AD9C5583; Thu, 15 Jun 2017 14:17:51 +0200 (CEST) In-Reply-To: <1497528973-16330-2-git-send-email-ciwillia@brocade.com> References: <1497528973-16330-2-git-send-email-ciwillia@brocade.com> To: test-report@dpdk.org Cc: Chas Williams Message-Id: <20170615121751.2AD9C5583@dpdk.org> Date: Thu, 15 Jun 2017 14:17:51 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw25350 [PATCH v2 1/6] net/vmxnet3: retain counters on restart X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jun 2017 12:17:51 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/25350 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: #70: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:832: + struct UPT1_TxStats *res) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'h' - possible side-effects? #72: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:834: +#define VMXNET3_UPDATE_TX_STAT(h, i, f, r) \ + ((r)->f = (h)->tqd_start[(i)].stats.f + \ + (h)->saved_tx_stats[(i)].f) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects? #72: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:834: +#define VMXNET3_UPDATE_TX_STAT(h, i, f, r) \ + ((r)->f = (h)->tqd_start[(i)].stats.f + \ + (h)->saved_tx_stats[(i)].f) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'f' - possible side-effects? #72: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:834: +#define VMXNET3_UPDATE_TX_STAT(h, i, f, r) \ + ((r)->f = (h)->tqd_start[(i)].stats.f + \ + (h)->saved_tx_stats[(i)].f) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'f' may be better as '(f)' to avoid precedence issues #72: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:834: +#define VMXNET3_UPDATE_TX_STAT(h, i, f, r) \ + ((r)->f = (h)->tqd_start[(i)].stats.f + \ + (h)->saved_tx_stats[(i)].f) CHECK:CAMELCASE: Avoid CamelCase: #76: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:838: + VMXNET3_UPDATE_TX_STAT(hw, q, ucastPktsTxOK, res); CHECK:CAMELCASE: Avoid CamelCase: #77: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:839: + VMXNET3_UPDATE_TX_STAT(hw, q, mcastPktsTxOK, res); CHECK:CAMELCASE: Avoid CamelCase: #78: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:840: + VMXNET3_UPDATE_TX_STAT(hw, q, bcastPktsTxOK, res); CHECK:CAMELCASE: Avoid CamelCase: #79: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:841: + VMXNET3_UPDATE_TX_STAT(hw, q, ucastBytesTxOK, res); CHECK:CAMELCASE: Avoid CamelCase: #80: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:842: + VMXNET3_UPDATE_TX_STAT(hw, q, mcastBytesTxOK, res); CHECK:CAMELCASE: Avoid CamelCase: #81: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:843: + VMXNET3_UPDATE_TX_STAT(hw, q, bcastBytesTxOK, res); CHECK:CAMELCASE: Avoid CamelCase: #82: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:844: + VMXNET3_UPDATE_TX_STAT(hw, q, pktsTxError, res); CHECK:CAMELCASE: Avoid CamelCase: #83: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:845: + VMXNET3_UPDATE_TX_STAT(hw, q, pktsTxDiscard, res); CHECK:CAMELCASE: Avoid CamelCase: #90: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:852: + struct UPT1_RxStats *res) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'h' - possible side-effects? #92: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:854: +#define VMXNET3_UPDATE_RX_STAT(h, i, f, r) \ + ((r)->f = (h)->rqd_start[(i)].stats.f + \ + (h)->saved_rx_stats[(i)].f) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects? #92: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:854: +#define VMXNET3_UPDATE_RX_STAT(h, i, f, r) \ + ((r)->f = (h)->rqd_start[(i)].stats.f + \ + (h)->saved_rx_stats[(i)].f) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'f' - possible side-effects? #92: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:854: +#define VMXNET3_UPDATE_RX_STAT(h, i, f, r) \ + ((r)->f = (h)->rqd_start[(i)].stats.f + \ + (h)->saved_rx_stats[(i)].f) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'f' may be better as '(f)' to avoid precedence issues #92: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:854: +#define VMXNET3_UPDATE_RX_STAT(h, i, f, r) \ + ((r)->f = (h)->rqd_start[(i)].stats.f + \ + (h)->saved_rx_stats[(i)].f) CHECK:CAMELCASE: Avoid CamelCase: #96: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:858: + VMXNET3_UPDATE_RX_STAT(hw, q, ucastPktsRxOK, res); CHECK:CAMELCASE: Avoid CamelCase: #97: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:859: + VMXNET3_UPDATE_RX_STAT(hw, q, mcastPktsRxOK, res); CHECK:CAMELCASE: Avoid CamelCase: #98: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:860: + VMXNET3_UPDATE_RX_STAT(hw, q, bcastPktsRxOK, res); CHECK:CAMELCASE: Avoid CamelCase: #99: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:861: + VMXNET3_UPDATE_RX_STAT(hw, q, ucastBytesRxOK, res); CHECK:CAMELCASE: Avoid CamelCase: #100: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:862: + VMXNET3_UPDATE_RX_STAT(hw, q, mcastBytesRxOK, res); CHECK:CAMELCASE: Avoid CamelCase: #101: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:863: + VMXNET3_UPDATE_RX_STAT(hw, q, bcastBytesRxOK, res); CHECK:CAMELCASE: Avoid CamelCase: #102: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:864: + VMXNET3_UPDATE_RX_STAT(hw, q, pktsRxError, res); CHECK:CAMELCASE: Avoid CamelCase: #103: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:865: + VMXNET3_UPDATE_RX_STAT(hw, q, pktsRxOutOfBuf, res); CHECK:CAMELCASE: Avoid CamelCase: #128: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:890: + struct UPT1_TxStats txStats; CHECK:CAMELCASE: Avoid CamelCase: #129: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:891: + struct UPT1_RxStats rxStats; total: 0 errors, 0 warnings, 28 checks, 157 lines checked