automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: [dpdk-test-report] |WARNING| pw25372 [PATCH 06/38] bus/dpaa: introducing FMan configurations
Date: Fri, 16 Jun 2017 07:33:44 +0200 (CEST)	[thread overview]
Message-ID: <20170616053344.261607D8B@dpdk.org> (raw)
In-Reply-To: <1497591668-3320-7-git-send-email-shreyansh.jain@nxp.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25372

_coding style issues_


ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1223: FILE: drivers/bus/dpaa/include/fman.h:416:
+#define ETH_MAC_PRINTF_ARGS(a) \
+		(a)->addr_bytes[0], (a)->addr_bytes[1], \
+		(a)->addr_bytes[2], (a)->addr_bytes[3], \
+		(a)->addr_bytes[4], (a)->addr_bytes[5]

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#1240: FILE: drivers/bus/dpaa/include/fman.h:433:
+#define FMAN_ERR(cond, rc, fmt, args...) \
+	do { \
+		if (unlikely(cond)) { \
+			_errno = (rc); \
+			DPAA_BUS_LOG(ERR, fmt "(%d)", ##args, errno); \
+			goto err; \
+		} \
+	} while (0)

total: 1 errors, 1 warnings, 1318 lines checked

           reply	other threads:[~2017-06-16  5:33 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1497591668-3320-7-git-send-email-shreyansh.jain@nxp.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170616053344.261607D8B@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=shreyansh.jain@nxp.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).