From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: [dpdk-test-report] |WARNING| pw25398 [PATCH 24/38] net/dpaa: add support for Tx and Rx queue setup
Date: Fri, 16 Jun 2017 07:40:17 +0200 (CEST) [thread overview]
Message-ID: <20170616054017.A37D24BE1@dpdk.org> (raw)
In-Reply-To: <1497591668-3320-25-git-send-email-shreyansh.jain@nxp.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25398
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_mbuf' - possible side-effects?
#504: FILE: drivers/net/dpaa/dpaa_rxtx.c:77:
+#define DPAA_MBUF_TO_CONTIG_FD(_mbuf, _fd, _bpid) \
+ do { \
+ (_fd)->cmd = 0; \
+ (_fd)->opaque_addr = 0; \
+ (_fd)->opaque = QM_FD_CONTIG << DPAA_FD_FORMAT_SHIFT; \
+ (_fd)->opaque |= ((_mbuf)->data_off) << DPAA_FD_OFFSET_SHIFT; \
+ (_fd)->opaque |= (_mbuf)->pkt_len; \
+ (_fd)->addr = (_mbuf)->buf_physaddr; \
+ (_fd)->bpid = _bpid; \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_fd' - possible side-effects?
#504: FILE: drivers/net/dpaa/dpaa_rxtx.c:77:
+#define DPAA_MBUF_TO_CONTIG_FD(_mbuf, _fd, _bpid) \
+ do { \
+ (_fd)->cmd = 0; \
+ (_fd)->opaque_addr = 0; \
+ (_fd)->opaque = QM_FD_CONTIG << DPAA_FD_FORMAT_SHIFT; \
+ (_fd)->opaque |= ((_mbuf)->data_off) << DPAA_FD_OFFSET_SHIFT; \
+ (_fd)->opaque |= (_mbuf)->pkt_len; \
+ (_fd)->addr = (_mbuf)->buf_physaddr; \
+ (_fd)->bpid = _bpid; \
+ } while (0)
WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#663: FILE: drivers/net/dpaa/dpaa_rxtx.c:236:
+ if (rte_mbuf_refcnt_read(mbuf) > 1) {
WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#667: FILE: drivers/net/dpaa/dpaa_rxtx.c:240:
+ } else {
WARNING:LONG_LINE: line over 90 characters
#669: FILE: drivers/net/dpaa/dpaa_rxtx.c:242:
+ &fd_arr[loop], bp_info->bpid);
WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#672: FILE: drivers/net/dpaa/dpaa_rxtx.c:245:
+ if (rte_mbuf_refcnt_read(mi) > 1) {
WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#675: FILE: drivers/net/dpaa/dpaa_rxtx.c:248:
+ } else {
WARNING:LONG_LINE: line over 90 characters
#678: FILE: drivers/net/dpaa/dpaa_rxtx.c:251:
+ &fd_arr[loop], bp_info->bpid);
total: 0 errors, 6 warnings, 752 lines checked
parent reply other threads:[~2017-06-16 5:40 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1497591668-3320-25-git-send-email-shreyansh.jain@nxp.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170616054017.A37D24BE1@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=shreyansh.jain@nxp.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).