automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw25398 [PATCH 24/38] net/dpaa: add support for Tx and Rx queue setup
       [not found] <1497591668-3320-25-git-send-email-shreyansh.jain@nxp.com>
@ 2017-06-16  5:40 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-06-16  5:40 UTC (permalink / raw)
  To: test-report; +Cc: Shreyansh Jain

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25398

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse '_mbuf' - possible side-effects?
#504: FILE: drivers/net/dpaa/dpaa_rxtx.c:77:
+#define DPAA_MBUF_TO_CONTIG_FD(_mbuf, _fd, _bpid) \
+	do { \
+		(_fd)->cmd = 0; \
+		(_fd)->opaque_addr = 0; \
+		(_fd)->opaque = QM_FD_CONTIG << DPAA_FD_FORMAT_SHIFT; \
+		(_fd)->opaque |= ((_mbuf)->data_off) << DPAA_FD_OFFSET_SHIFT; \
+		(_fd)->opaque |= (_mbuf)->pkt_len; \
+		(_fd)->addr = (_mbuf)->buf_physaddr; \
+		(_fd)->bpid = _bpid; \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_fd' - possible side-effects?
#504: FILE: drivers/net/dpaa/dpaa_rxtx.c:77:
+#define DPAA_MBUF_TO_CONTIG_FD(_mbuf, _fd, _bpid) \
+	do { \
+		(_fd)->cmd = 0; \
+		(_fd)->opaque_addr = 0; \
+		(_fd)->opaque = QM_FD_CONTIG << DPAA_FD_FORMAT_SHIFT; \
+		(_fd)->opaque |= ((_mbuf)->data_off) << DPAA_FD_OFFSET_SHIFT; \
+		(_fd)->opaque |= (_mbuf)->pkt_len; \
+		(_fd)->addr = (_mbuf)->buf_physaddr; \
+		(_fd)->bpid = _bpid; \
+	} while (0)

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#663: FILE: drivers/net/dpaa/dpaa_rxtx.c:236:
+						if (rte_mbuf_refcnt_read(mbuf) > 1) {

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#667: FILE: drivers/net/dpaa/dpaa_rxtx.c:240:
+						} else {

WARNING:LONG_LINE: line over 90 characters
#669: FILE: drivers/net/dpaa/dpaa_rxtx.c:242:
+								&fd_arr[loop], bp_info->bpid);

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#672: FILE: drivers/net/dpaa/dpaa_rxtx.c:245:
+						if (rte_mbuf_refcnt_read(mi) > 1) {

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#675: FILE: drivers/net/dpaa/dpaa_rxtx.c:248:
+						} else {

WARNING:LONG_LINE: line over 90 characters
#678: FILE: drivers/net/dpaa/dpaa_rxtx.c:251:
+								&fd_arr[loop], bp_info->bpid);

total: 0 errors, 6 warnings, 752 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-06-16  5:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1497591668-3320-25-git-send-email-shreyansh.jain@nxp.com>
2017-06-16  5:40 ` [dpdk-test-report] |WARNING| pw25398 [PATCH 24/38] net/dpaa: add support for Tx and Rx queue setup checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).