From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id A37D24BE1; Fri, 16 Jun 2017 07:40:17 +0200 (CEST)
In-Reply-To: <1497591668-3320-25-git-send-email-shreyansh.jain@nxp.com>
References: <1497591668-3320-25-git-send-email-shreyansh.jain@nxp.com>
To: test-report@dpdk.org
Cc: Shreyansh Jain <shreyansh.jain@nxp.com>
Message-Id: <20170616054017.A37D24BE1@dpdk.org>
Date: Fri, 16 Jun 2017 07:40:17 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw25398 [PATCH 24/38] net/dpaa: add
	support for Tx and Rx queue setup
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Jun 2017 05:40:18 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25398

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse '_mbuf' - possible side-effects?
#504: FILE: drivers/net/dpaa/dpaa_rxtx.c:77:
+#define DPAA_MBUF_TO_CONTIG_FD(_mbuf, _fd, _bpid) \
+	do { \
+		(_fd)->cmd = 0; \
+		(_fd)->opaque_addr = 0; \
+		(_fd)->opaque = QM_FD_CONTIG << DPAA_FD_FORMAT_SHIFT; \
+		(_fd)->opaque |= ((_mbuf)->data_off) << DPAA_FD_OFFSET_SHIFT; \
+		(_fd)->opaque |= (_mbuf)->pkt_len; \
+		(_fd)->addr = (_mbuf)->buf_physaddr; \
+		(_fd)->bpid = _bpid; \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_fd' - possible side-effects?
#504: FILE: drivers/net/dpaa/dpaa_rxtx.c:77:
+#define DPAA_MBUF_TO_CONTIG_FD(_mbuf, _fd, _bpid) \
+	do { \
+		(_fd)->cmd = 0; \
+		(_fd)->opaque_addr = 0; \
+		(_fd)->opaque = QM_FD_CONTIG << DPAA_FD_FORMAT_SHIFT; \
+		(_fd)->opaque |= ((_mbuf)->data_off) << DPAA_FD_OFFSET_SHIFT; \
+		(_fd)->opaque |= (_mbuf)->pkt_len; \
+		(_fd)->addr = (_mbuf)->buf_physaddr; \
+		(_fd)->bpid = _bpid; \
+	} while (0)

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#663: FILE: drivers/net/dpaa/dpaa_rxtx.c:236:
+						if (rte_mbuf_refcnt_read(mbuf) > 1) {

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#667: FILE: drivers/net/dpaa/dpaa_rxtx.c:240:
+						} else {

WARNING:LONG_LINE: line over 90 characters
#669: FILE: drivers/net/dpaa/dpaa_rxtx.c:242:
+								&fd_arr[loop], bp_info->bpid);

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#672: FILE: drivers/net/dpaa/dpaa_rxtx.c:245:
+						if (rte_mbuf_refcnt_read(mi) > 1) {

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#675: FILE: drivers/net/dpaa/dpaa_rxtx.c:248:
+						} else {

WARNING:LONG_LINE: line over 90 characters
#678: FILE: drivers/net/dpaa/dpaa_rxtx.c:251:
+								&fd_arr[loop], bp_info->bpid);

total: 0 errors, 6 warnings, 752 lines checked