automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: [dpdk-test-report] |WARNING| pw25401 [PATCH 35/38] net/dpaa: add support for packet type parsing
Date: Fri, 16 Jun 2017 07:42:02 +0200 (CEST)	[thread overview]
Message-ID: <20170616054202.5469058CE@dpdk.org> (raw)
In-Reply-To: <1497591668-3320-36-git-send-email-shreyansh.jain@nxp.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25401

_coding style issues_


ERROR:SPACING: space required after that close brace '}'
#324: FILE: drivers/net/dpaa/dpaa_rxtx.h:148:
+		}__attribute__((__packed__));

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#352: FILE: drivers/net/dpaa/dpaa_rxtx.h:176:
+#define first_ip_option        first_ip_err_code & 0x01

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#353: FILE: drivers/net/dpaa/dpaa_rxtx.h:177:
+#define first_unknown_ip_proto first_ip_err_code & 0x02

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#354: FILE: drivers/net/dpaa/dpaa_rxtx.h:178:
+#define first_fragmented       first_ip_err_code & 0x04

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#355: FILE: drivers/net/dpaa/dpaa_rxtx.h:179:
+#define first_ip_type          first_ip_err_code & 0x18

ERROR:SPACING: space required after that close brace '}'
#357: FILE: drivers/net/dpaa/dpaa_rxtx.h:181:
+		}__attribute__((__packed__));

CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_buf' may be better as '(_buf)' to avoid precedence issues
#401: FILE: drivers/net/dpaa/dpaa_rxtx.h:225:
+#define GET_RX_PRS(_buf) \
+	(struct dpaa_eth_parse_results_t *)((uint8_t *)_buf + DEFAULT_RX_ICEOF)

total: 6 errors, 0 warnings, 1 checks, 360 lines checked

           reply	other threads:[~2017-06-16  5:42 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1497591668-3320-36-git-send-email-shreyansh.jain@nxp.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170616054202.5469058CE@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=shreyansh.jain@nxp.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).