From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 5469058CE; Fri, 16 Jun 2017 07:42:02 +0200 (CEST)
In-Reply-To: <1497591668-3320-36-git-send-email-shreyansh.jain@nxp.com>
References: <1497591668-3320-36-git-send-email-shreyansh.jain@nxp.com>
To: test-report@dpdk.org
Cc: Shreyansh Jain <shreyansh.jain@nxp.com>
Message-Id: <20170616054202.5469058CE@dpdk.org>
Date: Fri, 16 Jun 2017 07:42:02 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw25401 [PATCH 35/38] net/dpaa: add
	support for packet type parsing
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Jun 2017 05:42:02 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25401

_coding style issues_


ERROR:SPACING: space required after that close brace '}'
#324: FILE: drivers/net/dpaa/dpaa_rxtx.h:148:
+		}__attribute__((__packed__));

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#352: FILE: drivers/net/dpaa/dpaa_rxtx.h:176:
+#define first_ip_option        first_ip_err_code & 0x01

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#353: FILE: drivers/net/dpaa/dpaa_rxtx.h:177:
+#define first_unknown_ip_proto first_ip_err_code & 0x02

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#354: FILE: drivers/net/dpaa/dpaa_rxtx.h:178:
+#define first_fragmented       first_ip_err_code & 0x04

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#355: FILE: drivers/net/dpaa/dpaa_rxtx.h:179:
+#define first_ip_type          first_ip_err_code & 0x18

ERROR:SPACING: space required after that close brace '}'
#357: FILE: drivers/net/dpaa/dpaa_rxtx.h:181:
+		}__attribute__((__packed__));

CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_buf' may be better as '(_buf)' to avoid precedence issues
#401: FILE: drivers/net/dpaa/dpaa_rxtx.h:225:
+#define GET_RX_PRS(_buf) \
+	(struct dpaa_eth_parse_results_t *)((uint8_t *)_buf + DEFAULT_RX_ICEOF)

total: 6 errors, 0 warnings, 1 checks, 360 lines checked