From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: [dpdk-test-report] |WARNING| pw25402 [PATCH 36/38] net/dpaa: add support for checksum offload
Date: Fri, 16 Jun 2017 07:42:03 +0200 (CEST) [thread overview]
Message-ID: <20170616054203.AD8AC58CE@dpdk.org> (raw)
In-Reply-To: <1497591668-3320-37-git-send-email-shreyansh.jain@nxp.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25402
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv4>
#84: FILE: drivers/net/dpaa/dpaa_rxtx.c:223:
+ if (eth_hdr->ether_type == htons(ETHER_TYPE_IPv4))
WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#143: FILE: drivers/net/dpaa/dpaa_rxtx.c:443:
+ if (mbuf->data_off < DEFAULT_TX_ICEOF +
WARNING:LONG_LINE: line over 90 characters
#144: FILE: drivers/net/dpaa/dpaa_rxtx.c:444:
+ sizeof(struct dpaa_eth_parse_results_t)) {
WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#150: FILE: drivers/net/dpaa/dpaa_rxtx.c:450:
+ } else
CHECK:BRACES: Unbalanced braces around else statement
#150: FILE: drivers/net/dpaa/dpaa_rxtx.c:450:
+ } else
WARNING:LONG_LINE: line over 90 characters
#151: FILE: drivers/net/dpaa/dpaa_rxtx.c:451:
+ dpaa_checksum_offload(mbuf, &fd_arr[loop],
CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_buf' may be better as '(_buf)' to avoid precedence issues
#188: FILE: drivers/net/dpaa/dpaa_rxtx.h:244:
+#define GET_TX_PRS(_buf) \
+ (struct dpaa_eth_parse_results_t *)((uint8_t *)_buf + DEFAULT_TX_ICEOF)
total: 0 errors, 4 warnings, 3 checks, 149 lines checked
parent reply other threads:[~2017-06-16 5:42 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1497591668-3320-37-git-send-email-shreyansh.jain@nxp.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170616054203.AD8AC58CE@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=shreyansh.jain@nxp.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).