From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Subject: [dpdk-test-report] |WARNING| pw25733 [PATCH v2 1/2] net/softnic: add softnic PMD for traffic management
Date: Thu, 29 Jun 2017 23:51:42 +0200 (CEST) [thread overview]
Message-ID: <20170629215142.35881378E@dpdk.org> (raw)
In-Reply-To: <20170626164334.50621-2-jasvinder.singh@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25733
_coding style issues_
WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#215: FILE: drivers/net/softnic/rte_eth_softnic.c:52:
+static const char *pmd_valid_args[] = {
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects?
#1684: FILE: drivers/net/softnic/rte_eth_softnic_default.c:876:
+#define CHECK_AND_SET_NULL(o, u, func) ({ \
+ if (!(u)->func) \
+ (o)->func = NULL; \
+})
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'func' may be better as '(func)' to avoid precedence issues
#1684: FILE: drivers/net/softnic/rte_eth_softnic_default.c:876:
+#define CHECK_AND_SET_NULL(o, u, func) ({ \
+ if (!(u)->func) \
+ (o)->func = NULL; \
+})
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'u' - possible side-effects?
#1689: FILE: drivers/net/softnic/rte_eth_softnic_default.c:881:
+#define CHECK_AND_SET_NONNULL(o, u, func) ({ \
+ if ((u)->func) \
+ (o)->func = (u)->func; \
+})
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects?
#1689: FILE: drivers/net/softnic/rte_eth_softnic_default.c:881:
+#define CHECK_AND_SET_NONNULL(o, u, func) ({ \
+ if ((u)->func) \
+ (o)->func = (u)->func; \
+})
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'func' may be better as '(func)' to avoid precedence issues
#1689: FILE: drivers/net/softnic/rte_eth_softnic_default.c:881:
+#define CHECK_AND_SET_NONNULL(o, u, func) ({ \
+ if ((u)->func) \
+ (o)->func = (u)->func; \
+})
total: 0 errors, 1 warnings, 1926 lines checked
parent reply other threads:[~2017-06-29 21:51 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20170626164334.50621-2-jasvinder.singh@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629215142.35881378E@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).