From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 35881378E; Thu, 29 Jun 2017 23:51:42 +0200 (CEST)
In-Reply-To: <20170626164334.50621-2-jasvinder.singh@intel.com>
References: <20170626164334.50621-2-jasvinder.singh@intel.com>
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Message-Id: <20170629215142.35881378E@dpdk.org>
Date: Thu, 29 Jun 2017 23:51:42 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw25733 [PATCH v2 1/2] net/softnic:
	add softnic PMD for traffic management
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jun 2017 21:51:42 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25733

_coding style issues_


WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#215: FILE: drivers/net/softnic/rte_eth_softnic.c:52:
+static const char *pmd_valid_args[] = {

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects?
#1684: FILE: drivers/net/softnic/rte_eth_softnic_default.c:876:
+#define CHECK_AND_SET_NULL(o, u, func)	({			\
+	if (!(u)->func)				\
+		(o)->func = NULL;				\
+})

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'func' may be better as '(func)' to avoid precedence issues
#1684: FILE: drivers/net/softnic/rte_eth_softnic_default.c:876:
+#define CHECK_AND_SET_NULL(o, u, func)	({			\
+	if (!(u)->func)				\
+		(o)->func = NULL;				\
+})

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'u' - possible side-effects?
#1689: FILE: drivers/net/softnic/rte_eth_softnic_default.c:881:
+#define CHECK_AND_SET_NONNULL(o, u, func)	({		\
+	if ((u)->func)				\
+		(o)->func = (u)->func;			\
+})

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects?
#1689: FILE: drivers/net/softnic/rte_eth_softnic_default.c:881:
+#define CHECK_AND_SET_NONNULL(o, u, func)	({		\
+	if ((u)->func)				\
+		(o)->func = (u)->func;			\
+})

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'func' may be better as '(func)' to avoid precedence issues
#1689: FILE: drivers/net/softnic/rte_eth_softnic_default.c:881:
+#define CHECK_AND_SET_NONNULL(o, u, func)	({		\
+	if ((u)->func)				\
+		(o)->func = (u)->func;			\
+})

total: 0 errors, 1 warnings, 1926 lines checked