automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jingjing Wu <jingjing.wu@intel.com>
Subject: [dpdk-test-report] |WARNING| pw25804 [PATCH v4 01/17] net/i40e/base: use new virtchnl header file
Date: Thu, 29 Jun 2017 23:53:48 +0200 (CEST)	[thread overview]
Message-ID: <20170629215348.4BBC5378E@dpdk.org> (raw)
In-Reply-To: <1498572056-72971-2-git-send-email-jingjing.wu@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25804

_coding style issues_


WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#626: FILE: drivers/net/i40e/base/virtchnl.h:2:
+/*******************************************************************************
+

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'n' - possible side-effects?
#784: FILE: drivers/net/i40e/base/virtchnl.h:160:
+#define VIRTCHNL_CHECK_STRUCT_LEN(n, X) enum virtchnl_static_assert_enum_##X \
+	{virtchnl_static_assert_##X = (n) / ((sizeof(struct X) == (n)) ? 1 : 0)}

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_v' - possible side-effects?
#825: FILE: drivers/net/i40e/base/virtchnl.h:201:
+#define VF_IS_V10(_v) (((_v)->major == 1) && ((_v)->minor == 0))

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_ver' - possible side-effects?
#826: FILE: drivers/net/i40e/base/virtchnl.h:202:
+#define VF_IS_V11(_ver) (((_ver)->major == 1) && ((_ver)->minor == 1))

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#1960: FILE: drivers/net/i40e/i40e_ethdev_vf.c:1179:
+		if (VIRTCHNL_VFR_COMPLETED == reset ||

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#1961: FILE: drivers/net/i40e/i40e_ethdev_vf.c:1180:
+		    VIRTCHNL_VFR_VFACTIVE == reset)

total: 0 errors, 3 warnings, 3 checks, 2248 lines checked

           reply	other threads:[~2017-06-29 21:53 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1498572056-72971-2-git-send-email-jingjing.wu@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170629215348.4BBC5378E@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).