From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 4BBC5378E; Thu, 29 Jun 2017 23:53:48 +0200 (CEST)
In-Reply-To: <1498572056-72971-2-git-send-email-jingjing.wu@intel.com>
References: <1498572056-72971-2-git-send-email-jingjing.wu@intel.com>
To: test-report@dpdk.org
Cc: Jingjing Wu <jingjing.wu@intel.com>
Message-Id: <20170629215348.4BBC5378E@dpdk.org>
Date: Thu, 29 Jun 2017 23:53:48 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw25804 [PATCH v4 01/17]
	net/i40e/base: use new virtchnl header file
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jun 2017 21:53:48 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25804

_coding style issues_


WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#626: FILE: drivers/net/i40e/base/virtchnl.h:2:
+/*******************************************************************************
+

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'n' - possible side-effects?
#784: FILE: drivers/net/i40e/base/virtchnl.h:160:
+#define VIRTCHNL_CHECK_STRUCT_LEN(n, X) enum virtchnl_static_assert_enum_##X \
+	{virtchnl_static_assert_##X = (n) / ((sizeof(struct X) == (n)) ? 1 : 0)}

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_v' - possible side-effects?
#825: FILE: drivers/net/i40e/base/virtchnl.h:201:
+#define VF_IS_V10(_v) (((_v)->major == 1) && ((_v)->minor == 0))

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_ver' - possible side-effects?
#826: FILE: drivers/net/i40e/base/virtchnl.h:202:
+#define VF_IS_V11(_ver) (((_ver)->major == 1) && ((_ver)->minor == 1))

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#1960: FILE: drivers/net/i40e/i40e_ethdev_vf.c:1179:
+		if (VIRTCHNL_VFR_COMPLETED == reset ||

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#1961: FILE: drivers/net/i40e/i40e_ethdev_vf.c:1180:
+		    VIRTCHNL_VFR_VFACTIVE == reset)

total: 0 errors, 3 warnings, 3 checks, 2248 lines checked