From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 12669378E; Thu, 29 Jun 2017 23:54:14 +0200 (CEST)
In-Reply-To: <1498572438-25125-6-git-send-email-wei.dai@intel.com>
References: <1498572438-25125-6-git-send-email-wei.dai@intel.com>
To: test-report@dpdk.org
Cc: Wei Dai <wei.dai@intel.com>
Message-Id: <20170629215414.12669378E@dpdk.org>
Date: Thu, 29 Jun 2017 23:54:14 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw25825 [PATCH v2 5/5] app/testpmd:
	add command to test NIC restoration
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jun 2017 21:54:14 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25825

_coding style issues_


WARNING:LONG_LINE: line over 90 characters
#106: FILE: app/test-pmd/config.c:3344:
+	printf("Begin to forward at least %d packets to test reconfiguration
", NUM_PACKETS);

WARNING:RETURN_VOID: void function return statements are not generally useful
#125: FILE: app/test-pmd/config.c:3363:
+	return;
+}

WARNING:LONG_LINE: line over 90 characters
#149: FILE: app/test-pmd/config.c:3387:
+		MBUF_CACHE_SIZE, 0, RTE_MBUF_DEFAULT_BUF_SIZE, rte_eth_dev_socket_id(port));

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#182: FILE: app/test-pmd/config.c:3420:
+			(unsigned)port,

total: 0 errors, 4 warnings, 151 lines checked