From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Olivier Chirossel <olivier.chirossel@gmail.com>
Subject: [dpdk-test-report] |WARNING| pw25988 [PATCH v2] lib/librte_sched: fix update tc_credits
Date: Thu, 29 Jun 2017 23:58:13 +0200 (CEST) [thread overview]
Message-ID: <20170629215813.9868E7CEB@dpdk.org> (raw)
In-Reply-To: <1498746942-1741-2-git-send-email-olivier.chirossel@gmail.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25988
_coding style issues_
ERROR:TRAILING_WHITESPACE: trailing whitespace
#56: FILE: lib/librte_sched/rte_sched.c:86:
+^Iuint32_t tc_rate[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE]; $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#74: FILE: lib/librte_sched/rte_sched.c:571:
+^I$
ERROR:CODE_INDENT: code indent should use tabs where possible
#76: FILE: lib/librte_sched/rte_sched.c:573:
+^I^I dst->tc_rate[j] = src->tc_rate[j];$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#81: FILE: lib/librte_sched/rte_sched.c:578:
+^I$
ERROR:CODE_INDENT: code indent should use tabs where possible
#89: FILE: lib/librte_sched/rte_sched.c:844:
+^I s->tc_rate[i] = params->tc_rate[i];$
ERROR:CODE_INDENT: code indent should use tabs where possible
#109: FILE: lib/librte_sched/rte_sched.c:1503:
+^I for (j = 0; j < RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE; j++) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 23)
#109: FILE: lib/librte_sched/rte_sched.c:1503:
+ for (j = 0; j < RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE; j++) {
+ if ((subport->tc_credits[j] + subport->tc_credits_per_period[j]) < subport->tc_rate[j]) {
WARNING:LONG_LINE: line over 90 characters
#110: FILE: lib/librte_sched/rte_sched.c:1504:
+ if ((subport->tc_credits[j] + subport->tc_credits_per_period[j]) < subport->tc_rate[j]) {
WARNING:TABSTOP: Statements should start on a tabstop
#110: FILE: lib/librte_sched/rte_sched.c:1504:
+ if ((subport->tc_credits[j] + subport->tc_credits_per_period[j]) < subport->tc_rate[j]) {
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (23, 30)
#110: FILE: lib/librte_sched/rte_sched.c:1504:
+ if ((subport->tc_credits[j] + subport->tc_credits_per_period[j]) < subport->tc_rate[j]) {
+ subport->tc_credits[j] += subport->tc_credits_per_period[j];
WARNING:BRACES: braces {} are not necessary for any arm of this statement
#110: FILE: lib/librte_sched/rte_sched.c:1504:
+ if ((subport->tc_credits[j] + subport->tc_credits_per_period[j]) < subport->tc_rate[j]) {
[...]
+ else {
[...]
ERROR:CODE_INDENT: code indent should use tabs where possible
#111: FILE: lib/librte_sched/rte_sched.c:1505:
+^I subport->tc_credits[j] += subport->tc_credits_per_period[j];$
WARNING:TABSTOP: Statements should start on a tabstop
#112: FILE: lib/librte_sched/rte_sched.c:1506:
+ }
WARNING:TABSTOP: Statements should start on a tabstop
#113: FILE: lib/librte_sched/rte_sched.c:1507:
+ else {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#113: FILE: lib/librte_sched/rte_sched.c:1507:
+ }
+ else {
WARNING:TABSTOP: Statements should start on a tabstop
#115: FILE: lib/librte_sched/rte_sched.c:1509:
+ }
ERROR:CODE_INDENT: code indent should use tabs where possible
#126: FILE: lib/librte_sched/rte_sched.c:1516:
+^I ^Ifor (j = 0; j < RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE; j++) {$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#126: FILE: lib/librte_sched/rte_sched.c:1516:
+^I ^Ifor (j = 0; j < RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE; j++) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 23)
#126: FILE: lib/librte_sched/rte_sched.c:1516:
+ for (j = 0; j < RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE; j++) {
+ if ((pipe->tc_credits[j] + params->tc_credits_per_period[j]) < params->tc_rate[j]) {
WARNING:LONG_LINE: line over 90 characters
#127: FILE: lib/librte_sched/rte_sched.c:1517:
+ if ((pipe->tc_credits[j] + params->tc_credits_per_period[j]) < params->tc_rate[j]) {
WARNING:TABSTOP: Statements should start on a tabstop
#127: FILE: lib/librte_sched/rte_sched.c:1517:
+ if ((pipe->tc_credits[j] + params->tc_credits_per_period[j]) < params->tc_rate[j]) {
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (23, 30)
#127: FILE: lib/librte_sched/rte_sched.c:1517:
+ if ((pipe->tc_credits[j] + params->tc_credits_per_period[j]) < params->tc_rate[j]) {
+ pipe->tc_credits[j] += params->tc_credits_per_period[j];
WARNING:BRACES: braces {} are not necessary for any arm of this statement
#127: FILE: lib/librte_sched/rte_sched.c:1517:
+ if ((pipe->tc_credits[j] + params->tc_credits_per_period[j]) < params->tc_rate[j]) {
[...]
+ else {
[...]
ERROR:CODE_INDENT: code indent should use tabs where possible
#128: FILE: lib/librte_sched/rte_sched.c:1518:
+^I pipe->tc_credits[j] += params->tc_credits_per_period[j];$
WARNING:TABSTOP: Statements should start on a tabstop
#129: FILE: lib/librte_sched/rte_sched.c:1519:
+ }
WARNING:TABSTOP: Statements should start on a tabstop
#130: FILE: lib/librte_sched/rte_sched.c:1520:
+ else {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#130: FILE: lib/librte_sched/rte_sched.c:1520:
+ }
+ else {
WARNING:TABSTOP: Statements should start on a tabstop
#132: FILE: lib/librte_sched/rte_sched.c:1522:
+ }
ERROR:CODE_INDENT: code indent should use tabs where possible
#155: FILE: lib/librte_sched/rte_sched.c:1590:
+^I for (j = 0; j < RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE; j++) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 23)
#155: FILE: lib/librte_sched/rte_sched.c:1590:
+ for (j = 0; j < RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE; j++) {
+ if ((subport->tc_credits[j] + subport->tc_credits_per_period[j]) < subport->tc_rate[j]) {
WARNING:LONG_LINE: line over 90 characters
#156: FILE: lib/librte_sched/rte_sched.c:1591:
+ if ((subport->tc_credits[j] + subport->tc_credits_per_period[j]) < subport->tc_rate[j]) {
WARNING:TABSTOP: Statements should start on a tabstop
#156: FILE: lib/librte_sched/rte_sched.c:1591:
+ if ((subport->tc_credits[j] + subport->tc_credits_per_period[j]) < subport->tc_rate[j]) {
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (23, 30)
#156: FILE: lib/librte_sched/rte_sched.c:1591:
+ if ((subport->tc_credits[j] + subport->tc_credits_per_period[j]) < subport->tc_rate[j]) {
+ subport->tc_credits[j] += subport->tc_credits_per_period[j];
WARNING:BRACES: braces {} are not necessary for any arm of this statement
#156: FILE: lib/librte_sched/rte_sched.c:1591:
+ if ((subport->tc_credits[j] + subport->tc_credits_per_period[j]) < subport->tc_rate[j]) {
[...]
+ else {
[...]
ERROR:CODE_INDENT: code indent should use tabs where possible
#157: FILE: lib/librte_sched/rte_sched.c:1592:
+^I subport->tc_credits[j] += subport->tc_credits_per_period[j];$
WARNING:TABSTOP: Statements should start on a tabstop
#158: FILE: lib/librte_sched/rte_sched.c:1593:
+ }
WARNING:TABSTOP: Statements should start on a tabstop
#159: FILE: lib/librte_sched/rte_sched.c:1594:
+ else {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#159: FILE: lib/librte_sched/rte_sched.c:1594:
+ }
+ else {
WARNING:TABSTOP: Statements should start on a tabstop
#161: FILE: lib/librte_sched/rte_sched.c:1596:
+ }
ERROR:TRAILING_WHITESPACE: trailing whitespace
#162: FILE: lib/librte_sched/rte_sched.c:1597:
+^I^I}^I$
ERROR:CODE_INDENT: code indent should use tabs where possible
#173: FILE: lib/librte_sched/rte_sched.c:1604:
+^I for (j = 0; j < RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE; j++) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 23)
#173: FILE: lib/librte_sched/rte_sched.c:1604:
+ for (j = 0; j < RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE; j++) {
+ if ((pipe->tc_credits[j] + params->tc_credits_per_period[j]) < params->tc_rate[j]) {
WARNING:LONG_LINE: line over 90 characters
#174: FILE: lib/librte_sched/rte_sched.c:1605:
+ if ((pipe->tc_credits[j] + params->tc_credits_per_period[j]) < params->tc_rate[j]) {
WARNING:TABSTOP: Statements should start on a tabstop
#174: FILE: lib/librte_sched/rte_sched.c:1605:
+ if ((pipe->tc_credits[j] + params->tc_credits_per_period[j]) < params->tc_rate[j]) {
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (23, 30)
#174: FILE: lib/librte_sched/rte_sched.c:1605:
+ if ((pipe->tc_credits[j] + params->tc_credits_per_period[j]) < params->tc_rate[j]) {
+ pipe->tc_credits[j] += params->tc_credits_per_period[j];
WARNING:BRACES: braces {} are not necessary for any arm of this statement
#174: FILE: lib/librte_sched/rte_sched.c:1605:
+ if ((pipe->tc_credits[j] + params->tc_credits_per_period[j]) < params->tc_rate[j]) {
[...]
+ else {
[...]
ERROR:CODE_INDENT: code indent should use tabs where possible
#175: FILE: lib/librte_sched/rte_sched.c:1606:
+^I pipe->tc_credits[j] += params->tc_credits_per_period[j];$
WARNING:TABSTOP: Statements should start on a tabstop
#176: FILE: lib/librte_sched/rte_sched.c:1607:
+ }
WARNING:TABSTOP: Statements should start on a tabstop
#177: FILE: lib/librte_sched/rte_sched.c:1608:
+ else {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#177: FILE: lib/librte_sched/rte_sched.c:1608:
+ }
+ else {
WARNING:TABSTOP: Statements should start on a tabstop
#179: FILE: lib/librte_sched/rte_sched.c:1610:
+ }
total: 18 errors, 33 warnings, 146 lines checked
parent reply other threads:[~2017-06-29 21:58 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1498746942-1741-2-git-send-email-olivier.chirossel@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629215813.9868E7CEB@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=olivier.chirossel@gmail.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).