From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 0E8BC7CEB; Thu, 29 Jun 2017 23:58:31 +0200 (CEST)
In-Reply-To: <20170629162022.9984-2-tomaszx.kulasek@intel.com>
References: <20170629162022.9984-2-tomaszx.kulasek@intel.com>
To: test-report@dpdk.org
Cc: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Message-Id: <20170629215831.0E8BC7CEB@dpdk.org>
Date: Thu, 29 Jun 2017 23:58:31 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw25997 [PATCH v2 1/2] LACP control
	packet filtering offload
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jun 2017 21:58:31 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25997

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#19: 
rte_eth_bond_8023ad_slow_pkt_hw_filter_enable should be called before bonding

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#62: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:638:
+			/* If TX ring full, drop packet and free message.
+			   Retransmission will happen in next function call. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#62: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:638:
+			   Retransmission will happen in next function call. */

CHECK:BRACES: Unbalanced braces around else statement
#97: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:765:
+	} else

WARNING:LONG_LINE: line over 90 characters
#135: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:852:
+				bond_mode_8023ad_handle_slow_pkt(internals, slave_id, lacp_pkt);

CHECK:BRACES: Unbalanced braces around else statement
#193: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1251:
+		} else

CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#445: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:221:
+			if ((slave_info.max_rx_queues < bond_info.nb_rx_queues)
+					|| (slave_info.max_rx_queues <

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#460: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:236:
+bond_ethdev_8023ad_flow_set(struct rte_eth_dev *bond_dev, uint8_t slave_port) {
+

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#505: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:281:
+	 * bursting */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#548: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:324:
+	 * bursting */

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#611: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:427:
 		while (j < num_rx_total) {
+

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#689: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1604:
+		 * resources can't be free, so reinitialization is impossible. */

WARNING:LONG_LINE: line over 90 characters
#796: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1755:
+					internals->mode4.slow_pkts.flow[slave_eth_dev->data->port_id],

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#839: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:2070:
+		 * support is the minimum values of the bonded slaves */

total: 0 errors, 9 warnings, 5 checks, 801 lines checked