From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 0D9B2567E; Fri, 30 Jun 2017 14:39:15 +0200 (CEST)
In-Reply-To: <1498826274-1769-1-git-send-email-wei.guo.simon@gmail.com>
References: <1498826274-1769-1-git-send-email-wei.guo.simon@gmail.com>
To: test-report@dpdk.org
Cc: wei.guo.simon@gmail.com
Message-Id: <20170630123915.0D9B2567E@dpdk.org>
Date: Fri, 30 Jun 2017 14:39:15 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw26089 [PATCH RFC] app/testpmd: add
	option ring-bind-lcpu to bind Q with CPU
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Jun 2017 12:39:15 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/26089

_coding style issues_


WARNING:TYPO_SPELLING: 'overriden' may be misspelled - perhaps 'overridden'?
#50: FILE: app/test-pmd/parameters.c:135:
+		" It will overriden ring-numa-config or port-numa-config if success."

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#52: FILE: app/test-pmd/parameters.c:137:
+		" It allows one port binds to multiple NUMA nodes. 
");

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#83: FILE: app/test-pmd/testpmd.c:101:
+uint8_t ring_bind_lcpu = 0;

ERROR:CODE_INDENT: code indent should use tabs where possible
#138: FILE: app/test-pmd/testpmd.c:1489:
+                                int socket = port->socket_id;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#138: FILE: app/test-pmd/testpmd.c:1489:
+                                int socket = port->socket_id;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#147: FILE: app/test-pmd/testpmd.c:1492:
+                                        socket = txring_numa[pi];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#147: FILE: app/test-pmd/testpmd.c:1492:
+                                        socket = txring_numa[pi];$

ERROR:SPACING: space required after that ',' (ctx:VxV)
#210: FILE: app/test-pmd/testpmd.c:1541:
+						nb_rxd,socket,
 						      ^

total: 4 errors, 4 warnings, 167 lines checked