From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id D13AC7CD6; Wed,  5 Jul 2017 02:11:22 +0200 (CEST)
In-Reply-To: <1499179471-19145-38-git-send-email-shreyansh.jain@nxp.com>
References: <1499179471-19145-38-git-send-email-shreyansh.jain@nxp.com>
To: test-report@dpdk.org
Cc: Shreyansh Jain <shreyansh.jain@nxp.com>
Message-Id: <20170705001122.D13AC7CD6@dpdk.org>
Date: Wed,  5 Jul 2017 02:11:22 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw26419 [PATCH v2 37/40] net/dpaa: add
	support for checksum offload
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Jul 2017 00:11:23 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/26419

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv4>
#84: FILE: drivers/net/dpaa/dpaa_rxtx.c:228:
+		if (eth_hdr->ether_type == htons(ETHER_TYPE_IPv4))

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#143: FILE: drivers/net/dpaa/dpaa_rxtx.c:448:
+						if (mbuf->data_off < DEFAULT_TX_ICEOF +

WARNING:LONG_LINE: line over 90 characters
#144: FILE: drivers/net/dpaa/dpaa_rxtx.c:449:
+							sizeof(struct dpaa_eth_parse_results_t)) {

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#150: FILE: drivers/net/dpaa/dpaa_rxtx.c:455:
+						} else

CHECK:BRACES: Unbalanced braces around else statement
#150: FILE: drivers/net/dpaa/dpaa_rxtx.c:455:
+						} else

WARNING:LONG_LINE: line over 90 characters
#151: FILE: drivers/net/dpaa/dpaa_rxtx.c:456:
+							dpaa_checksum_offload(mbuf, &fd_arr[loop],

CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_buf' may be better as '(_buf)' to avoid precedence issues
#188: FILE: drivers/net/dpaa/dpaa_rxtx.h:244:
+#define GET_TX_PRS(_buf) \
+	(struct dpaa_eth_parse_results_t *)((uint8_t *)_buf + DEFAULT_TX_ICEOF)

total: 0 errors, 4 warnings, 3 checks, 149 lines checked