From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Declan Doherty <declan.doherty@intel.com>
Subject: [dpdk-test-report] |WARNING| pw26445 [PATCH v3 3/4] net/bond: dedicated hw queues for LACP control traffic
Date: Wed, 5 Jul 2017 02:12:05 +0200 (CEST) [thread overview]
Message-ID: <20170705001205.E6F297CBD@dpdk.org> (raw)
In-Reply-To: <20170704164627.324-4-declan.doherty@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/26445
_coding style issues_
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#73: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:642:
+ /* If TX ring full, drop packet and free message.
+ Retransmission will happen in next function call. */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#73: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:642:
+ Retransmission will happen in next function call. */
CHECK:BRACES: Unbalanced braces around else statement
#109: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:768:
+ } else
CHECK:BRACES: Unbalanced braces around else statement
#221: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1263:
+ } else
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#490: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:234:
+bond_ethdev_8023ad_flow_set(struct rte_eth_dev *bond_dev, uint8_t slave_port) {
+
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#535: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:279:
+ * bursting */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#583: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:327:
+ * bursting */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#693: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1608:
+ * resources can't be free, so reinitialization is impossible. */
WARNING:LONG_LINE: line over 90 characters
#798: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1757:
+ if (internals->mode4.dedicated_queues.flow[slave_eth_dev->data->port_id] != NULL)
WARNING:LONG_LINE: line over 90 characters
#800: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1759:
+ internals->mode4.dedicated_queues.flow[slave_eth_dev->data->port_id],
WARNING:MISSING_SPACE: break quoted strings at a space character
#835: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1941:
+ "bonded port (%d) failed to reconfigure"
+ "slave device (%d)",
total: 0 errors, 8 warnings, 3 checks, 812 lines checked
parent reply other threads:[~2017-07-05 0:12 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20170704164627.324-4-declan.doherty@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705001205.E6F297CBD@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=declan.doherty@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).