From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id E6F297CBD; Wed,  5 Jul 2017 02:12:05 +0200 (CEST)
In-Reply-To: <20170704164627.324-4-declan.doherty@intel.com>
References: <20170704164627.324-4-declan.doherty@intel.com>
To: test-report@dpdk.org
Cc: Declan Doherty <declan.doherty@intel.com>
Message-Id: <20170705001205.E6F297CBD@dpdk.org>
Date: Wed,  5 Jul 2017 02:12:05 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw26445 [PATCH v3 3/4] net/bond:
	dedicated hw queues for LACP control traffic
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Jul 2017 00:12:06 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/26445

_coding style issues_


WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#73: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:642:
+			/* If TX ring full, drop packet and free message.
+			   Retransmission will happen in next function call. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#73: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:642:
+			   Retransmission will happen in next function call. */

CHECK:BRACES: Unbalanced braces around else statement
#109: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:768:
+	} else

CHECK:BRACES: Unbalanced braces around else statement
#221: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1263:
+		} else

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#490: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:234:
+bond_ethdev_8023ad_flow_set(struct rte_eth_dev *bond_dev, uint8_t slave_port) {
+

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#535: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:279:
+	 * bursting */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#583: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:327:
+	 * bursting */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#693: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1608:
+		 * resources can't be free, so reinitialization is impossible. */

WARNING:LONG_LINE: line over 90 characters
#798: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1757:
+		if (internals->mode4.dedicated_queues.flow[slave_eth_dev->data->port_id] != NULL)

WARNING:LONG_LINE: line over 90 characters
#800: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1759:
+					internals->mode4.dedicated_queues.flow[slave_eth_dev->data->port_id],

WARNING:MISSING_SPACE: break quoted strings at a space character
#835: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1941:
+					"bonded port (%d) failed to reconfigure"
+					"slave device (%d)",

total: 0 errors, 8 warnings, 3 checks, 812 lines checked