From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Nikhil Rao <nikhil.rao@intel.com>
Subject: [dpdk-test-report] |WARNING| pw26534 [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues
Date: Thu, 6 Jul 2017 15:16:38 +0200 (CEST) [thread overview]
Message-ID: <20170706131638.2E2034BE1@dpdk.org> (raw)
In-Reply-To: <1499377952-5306-1-git-send-email-nikhil.rao@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/26534
_coding style issues_
WARNING:LONG_LINE: line over 90 characters
#339: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.h:253:
+ const struct rte_event_eth_rx_adapter_queue_conf *conf);
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#916: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:523:
+ unsigned sz;
WARNING:LONG_LINE: line over 90 characters
#940: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:547:
+ rss_key_be = (void *)&rte_event_eth_rx_adapter[RTE_MAX_EVENT_ETH_RX_ADAPTER_INSTANCE];
WARNING:BRACES: braces {} are not necessary for single statement blocks
#960: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:567:
+ if (rte_event_eth_rx_adapter[id]) {
+ return -EEXIST;
+ }
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#1041: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:648:
+ for (i = 0; i < rte_eth_dev_count(); i++)
+ rte_free(rx_adapter->eth_devices[i].rx_queue);
WARNING:LONG_LINE: line over 90 characters
#1075: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:682:
+ const struct rte_event_eth_rx_adapter_queue_conf *conf)
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'conf->rx_queue_flags'
#1103: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:710:
+ if (conf->
+ rx_queue_flags & RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID) {
total: 0 errors, 7 warnings, 1164 lines checked
parent reply other threads:[~2017-07-06 13:16 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1499377952-5306-1-git-send-email-nikhil.rao@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706131638.2E2034BE1@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=nikhil.rao@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).